Changes in Makefile

63e0c25dad5f2793fdb9ff9b1e6ce516673dc6aa - bdev: add reset_mode to bdev_get_iostat

Thu, 12 Sep 2024 15:27:25 +0000

bdev: add reset_mode to bdev_get_iostatIn current implementation of resetting stats explicit bdev_reset_iostatcall is needed. It is not optimal for usecaseswhen stat is obtained periodically and then resetted, becausesome stats may be lost in between of get and reset.Introduce new option for bdev_get_iostat that allows to reset statright after obtaining it.Fixes #3525Change-Id: I77a5ea9310718c25e678336e2450a04fb582c050Signed-off-by: Vasilii Ivanov Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24900Community-CI: Mellanox Build BotReviewed-by: Jim Harris Community-CI: Broadcom CI Reviewed-by: Shuhei Matsumoto Reviewed-by: Konrad Sztyber Tested-by: SPDK CI Jenkins List of files: /spdk/lib/bdev/Makefile

f3cef5e128920a3f4d48d5bd99fed7833445c125 - bdev: Add bdev_enable_histogram filter

Wed, 12 Jun 2024 19:36:12 +0000

bdev: Add bdev_enable_histogram filterAdded new --opc parameter to bdev_enable_histogram RPC.It facilitates user to capture histogram data points for the specifiedIO type.Refer to bdev_get_bdevs RPC for list of io types.Change-Id: I3b70296ae32adc80f894e19426af22da0ac70802Signed-off-by: Atul Malakar Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/23488Reviewed-by: Tomasz Zawadzki Reviewed-by: Jim Harris Community-CI: Mellanox Build BotTested-by: SPDK CI Jenkins List of files: /spdk/lib/bdev/Makefile

db8a9711494474b4780f022b5a93a15f61fe0a7e - bdev: Add helper function to get IO type strings

Wed, 12 Jun 2024 16:31:06 +0000

bdev: Add helper function to get IO type stringsA helper function spdk_bdev_get_io_type_name andstring array g_io_type_strings is added to translatespdk_bdev_io_type enum to string value.Change-Id: Ie787eb2c7c170ba2e3ba01d492ca8628a0d4f976Signed-off-by: Atul Malakar Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/23660Tested-by: SPDK CI Jenkins Community-CI: Mellanox Build BotReviewed-by: Jim Harris Reviewed-by: Aleksey Marchuk List of files: /spdk/lib/bdev/Makefile

61623c5ca925d33f0eb8d017d63ec5685f40615d - bdev: add spdk_bdev_io padding in place of io_submit_ch

Thu, 25 Jan 2024 11:16:09 +0000

bdev: add spdk_bdev_io padding in place of io_submit_chCommit 055de83ac ("bdev: multiple QoS queues with atomic-based QoSquota") changed the way bdev layer handles IOs with QoS enabled. Itshouldn't affect IOs when QoS is disabled. However, apparently, thischange *has* shown performance drop on some workloads. Specifically,single core bdepverf performance running on 7 Kioxia KCM61VUL3T20 driveswith qd=192 went down from ~5.9M to ~5.4M.As part of that commit, the layout of struct spdk_bdev_io has beenchanged due to removing io_submit_ch. Re-adding the padding in place ofthat field has proven to improve IOPS in the case mentioned above from~5.3M (current master) to ~5.7M. This patch does exactly that, but weshould look into the layout of this structure more thoroughly in thefuture.Signed-off-by: Konrad Sztyber Change-Id: I35a04b93bec54620a6a2c8f1133870f5f101eda9Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/21576Reviewed-by: Tomasz Zawadzki Reviewed-by: Jim Harris Reviewed-by: Aleksey Marchuk Community-CI: Mellanox Build BotTested-by: SPDK CI Jenkins List of files: /spdk/lib/bdev/Makefile

b2a154ead33a691c46679a4af5374f5435ce0e10 - mk: Shuffle compiler opts for VTune

Fri, 08 Dec 2023 10:47:03 +0000

mk: Shuffle compiler opts for VTuneChange-Id: I841cf2e055b744020c641f496936a6a9c022a2c1Signed-off-by: Alexey Kireev Signed-off-by: Michal Berger Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/20967Reviewed-by: Ben Walker Reviewed-by: Jim Harris Community-CI: Mellanox Build BotTested-by: SPDK CI Jenkins Reviewed-by: Tomasz Zawadzki List of files: /spdk/lib/bdev/Makefile

055de83ac62de00d8c6214825cc5af86f5201b9c - bdev: multiple QoS queues with atomic-based QoS quota

Thu, 02 Mar 2023 09:54:48 +0000

bdev: multiple QoS queues with atomic-based QoS quotaHere's a comparison of the legacy and the atomic-based QoS.Tested with bdevperf + 1 null or malloc bdev. When the Qos is enabledthe limit set to the value higher than the setup is capable of achieving(900.000.000 IOPs).| bdev | CPU | No QoS | Legacy QoS | Atomic QoS | LP | AP || | Mask | | (IOPS) | (IOPS) | (%) | (%) ||--------|------|--------------|------------|-------------|-----|-----|| null | 1 | 10807210.39 | 8720802.93 | 8883633.79 | 19 | 18 || null | 3 | 21065293.41 | 7798114.51 | 8605514.14 | 63 | 59 || null | 7 | 31941220.35 | 8026022.82 | 11057120.85 | 75 | 65 || null | F | 42510017.40 | 7655892.00 | 11832259.16 | 82 | 72 || null | FF | 80864836.44 | 7598421.52 | 13096449.71 | 91 | 84 || null | FFF | 121780455.70 | 7609117.22 | 11030412.77 | 94 | 91 || null | FFFF | 162071300.70 | 7558077.12 | 10826030.57 | 95 | 93 || malloc | 1 | 1948096.14 | 1863817.94 | 1881245.75 | 4 | 3 || malloc | 3 | 3803549.11 | 2068897.67 | 3155528.57 | 46 | 17 || malloc | 7 | 5593798.24 | 2227017.22 | 4387343.78 | 60 | 22 || malloc | F | 7231720.95 | 2281762.70 | 5797832.38 | 68 | 20 || malloc | FF | 12070891.12 | 2614674.11 | 9690367.72 | 78 | 20 || malloc | FFF | 13989626.48 | 2630881.18 | 12840411.99 | 81 | 8 || malloc | FFFF | 14405443.97 | 2600775.13 | 9992956.98 | 82 | 31 |Change-Id: Ia91706b761e085b4231a2fb9a08565c305735b7dSigned-off-by: Anton Nayshtut Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/18914Reviewed-by: Ben Walker Community-CI: Mellanox Build BotTested-by: SPDK CI Jenkins Reviewed-by: Jim Harris List of files: /spdk/lib/bdev/Makefile

01ccef6e824b765c3f1a558e2fe37637df402306 - bdev: allow bdevs to specify max size of IOs

Wed, 15 Nov 2023 11:12:52 +0000

bdev: allow bdevs to specify max size of IOsThere are cases when a bdev module needs to limit the maximum size of anIO to a certain value (e.g. large iobuf if it needs to allocate a bouncebuffer).Previously, this was covered by specifying optimal_io_boundary andsetting the split_on_optimal_io_boundary flag. However, this can beinefficient, as it'll also split smaller requests that do not exceed themaximum size, but cross the boundary. For instance, withoptimal_io_boundary=4, an IO with offset_blocks=3, num_blocks=2 will besplit.To avoid that, a new field, max_rw_size, is introduced to allow forspecifying the maximum size of an IO without taking into accountoffset_blocks. It only affects READ and WRITE requests, as other IOtypes are already controlled by other values (e.g. max_unmap, max_copy,max_write_zeroes).Signed-off-by: Konrad Sztyber Change-Id: Idcafdeaf22a34f25aa599f03726caa9307949e1fReviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/20584Community-CI: Mellanox Build BotTested-by: SPDK CI Jenkins Reviewed-by: Aleksey Marchuk Reviewed-by: Jim Harris List of files: /spdk/lib/bdev/Makefile

09fe539bad3715d18bf7c11f5e40ac5ae396d597 - bdev: track IOs with accel sequence with an extra flag

Mon, 05 Jun 2023 12:11:09 +0000

bdev: track IOs with accel sequence with an extra flagWe already have u.bdev.accel_sequence and internal.accel_sequence, butboth of them can be cleared in different cases. The former is clearedwhen a bdev doesn't support accel or by the module itself to notify bdevlayer that it executed the sequence. The latter is cleared beforesubmitting a request to a module supporting accel, so that bdev layerwon't touch it again.However, there are cases where it's necessary to know whether an IO wasassociated with an accel sequence and a module has executed it (e.g. toallow modules support accel without supporting memory domains), so anextra flag is required.Signed-off-by: Konrad Sztyber Change-Id: I58ec789cce84b63151d02e28a0bb3d3bbf85f7bfReviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/18771Community-CI: Mellanox Build BotReviewed-by: Aleksey Marchuk Tested-by: SPDK CI Jenkins Reviewed-by: Shuhei Matsumoto List of files: /spdk/lib/bdev/Makefile

3359bf34d682202107c227ea42ace1c600a04657 - so_ver: increase all major versions

Mon, 23 Jan 2023 17:24:28 +0000

so_ver: increase all major versionsTo allow SO_MINOR updates on LTS for the whole year it is supported,the major version for all components needs to be increased.This is to prevent scenario where two versions exists with matchingversions, but conflicting ABI.Ex. Next SPDK release adds an API call increasing the minor version,then LTS needs just a subset of those additions.Increasing major so version after LTS, allows the future releasesto update versions as needed. Yet allowing LTS to increase minorversion separately.Disabled test for increasing SO version without ABI change, asthat is goal of this patch. This check shall be removed with SPDK 23.05release.Looks like this was left over from prior LTS, to avoid thatmake sure it is only skipped when running against v23.01.x as latestrelease.This patch:- increases SO_VER by 1 for all components- resets SO_MINOR to 0 for all components- removes suppressions for ABI testsShort reference to how the versions were changed:MAX=$(git grep "SO_VER := " | cut -d" " -f 3 | sort -ubnr | head -1)for((i=$MAX;i>0;i-=1)); do find . -name "Makefile" -exec \ sed -i -e "s/SO_VER := $i\$/SO_VER := $(($i+1))/g" {} +; donefind . -name "Makefile" -exec \ sed -i -e "s/SO_MINOR := .*/SO_MINOR := 0/g" {} +Change-Id: I3e5681802c0a5ac6d7d652a18896997cd07cc8bfSigned-off-by: Tomasz Zawadzki Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/16419Reviewed-by: Ben Walker Reviewed-by: Konrad Sztyber Tested-by: SPDK CI Jenkins List of files: /spdk/lib/bdev/Makefile

a6dbe3721eb3b5990707fc3e378c95e505dd8ab5 - update Intel copyright notices

Tue, 01 Nov 2022 20:26:26 +0000

update Intel copyright noticesper Intel policy to include file commit date using git cmdbelow. The policy does not apply to non-Intel (C) notices.git log --follow -C90% --format=%ad --date default | tail -1and then pull just the 4 digit year from the result.Intel copyrights were not added to files where Intel either hadno contribution ot the contribution lacked substance (ie licenseheader updates, formatting changes, etc). Contribution date used"--follow -C95%" to get the most accurate date.Note that several files in this patch didn't end the license/(c)block with a blank comment line so these were added as the vastmajority of files do have this last blank line. Simply there forconsistency.Signed-off-by: paul luse Change-Id: Id5b7ce4f658fe87132f14139ead58d6e285c04d4Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/15192Tested-by: SPDK CI Jenkins Reviewed-by: Jim Harris Reviewed-by: Ben Walker Community-CI: Mellanox Build Bot List of files: /spdk/lib/bdev/Makefile

d14afd5000f77b8bcf093951b99bc47979f244e7 - bdev: Add copy IO type

Mon, 22 Aug 2022 09:14:48 +0000

bdev: Add copy IO typeCopy operation is defined by source and destination LBAs and LBA countto copy. For destiantion LBA and LBA count we reuse exiting fields`offset_blocks` and `num_blocks` in `struct spdk_bdev_io`. For sourceLBA new field `src_offset_blocks` was added.`spdk_bdev_get_max_copy()` function can be used to retrieve maximumpossible unsplit copy size. Zero values means unlimited. It is allowedto submit larger copy size but it will be split into several bdev IOs.Signed-off-by: Evgeniy Kochetov Change-Id: I2ad56294b6c062595c026ffcf9b435f0100d3d7eReviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/14344Tested-by: SPDK CI Jenkins Reviewed-by: Ben Walker Reviewed-by: Aleksey Marchuk Reviewed-by: Shuhei Matsumoto Community-CI: Mellanox Build Bot List of files: /spdk/lib/bdev/Makefile

f0494649e3019937526c8f4dac507b1350cb80d7 - Lib/Bdev: add the new API spdk_bdev_for_each_channel

Thu, 22 Sep 2022 01:32:37 +0000

Lib/Bdev: add the new API spdk_bdev_for_each_channelAnd also related function pointers and APIs: spdk_bdev_for_each_channel_msg; spdk_bdev_for_each_channel_done; spdk_bdev_for_each_channel_continue;Change-Id: I52f0f6f27717d53c238faf2f998810c9c5ee45d4Signed-off-by: GangCao Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/14614Tested-by: SPDK CI Jenkins Reviewed-by: Shuhei Matsumoto Reviewed-by: Jim Harris Community-CI: Mellanox Build Bot List of files: /spdk/lib/bdev/Makefile

48ce2c978e1c3f0da66a2721d5a8bda4d53ab131 - Bdev: remove the QD poller at the time of Bdev unregister

Sat, 11 Jun 2022 07:05:07 +0000

Bdev: remove the QD poller at the time of Bdev unregisterFix issue: #2561The issue here is that in the bdev_set_qd_sampling_period RPCcommand, the QD sampling period has been set. Then later therelated Desc is closed and in the bdev_close() function theQD sampling period is reset to 0.A new QD desc is added as the QD sampling period update couldbe handled properly.Meanwhile, a new QD Poll In Progress flag is also added so asto indicate there are ongoing events of QD sampling and theBdev unregister will be handled in the proper way.Related test case and unit test also updated for this change.Change-Id: Iac86c2c6447fe338c7480cf468897fc8f41f8741Signed-off-by: Shuhei Matsumoto Signed-off-by: GangCao Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/13016Tested-by: SPDK CI Jenkins Reviewed-by: Jim Harris Community-CI: Broadcom CI Community-CI: Mellanox Build Bot List of files: /spdk/lib/bdev/Makefile

488570ebd418ba07c9e69e65106dcc964f3bb41b - Replace most BSD 3-clause license text with SPDX identifier.

Fri, 03 Jun 2022 19:15:11 +0000

Replace most BSD 3-clause license text with SPDX identifier.Many open source projects have moved to using SPDX identifiersto specify license information, reducing the amount ofboilerplate code in every source file. This patch replacesthe bulk of SPDK .c, .cpp and Makefiles with the BSD-3-Clauseidentifier.Almost all of these files share the exact same license text,and this patch only modifies the files that contain themost common license text. There can be slight variationsbecause the third clause contains company names - most say"Intel Corporation", but there are instances for Nvidia,Samsung, Eideticom and even "the copyright holder".Used a bash script to automate replacement of the license textwith SPDX identifier which is checked into scripts/spdx.sh.Signed-off-by: Jim Harris Change-Id: Iaa88ab5e92ea471691dc298cfe41ebfb5d169780Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/12904Community-CI: Broadcom CI Community-CI: Mellanox Build BotTested-by: SPDK CI Jenkins Reviewed-by: Aleksey Marchuk Reviewed-by: Changpeng Liu Reviewed-by: Dong Yi Reviewed-by: Konrad Sztyber Reviewed-by: Paul Luse Reviewed-by: List of files: /spdk/lib/bdev/Makefile

047c067c05ff22df06c053990998184b8a940514 - so_ver: increase all major versions

Mon, 31 Jan 2022 09:55:58 +0000

so_ver: increase all major versionsTo allow SO_MINOR updates on LTS for the whole year it is supported,the major version for all components needs to be increased.This is to prevent scenario where two versions exists with matchingversions, but conflicting ABI.Ex. Next SPDK release adds an API call increasing the minor version,then LTS needs just a subset of those additions.Increasing major so version after LTS, allows the future releasesto update versions as needed. Yet allowing LTS to increase minorversion separately.Disabled test for increasing SO version without ABI change, asthat is goal of this patch. This check shall be removed with SPDK 22.05release.This patch:- increases SO_VER by 1 for all components- resets SO_MINOR to 0 for all components- removes suppressions for ABI testsSigned-off-by: Tomasz Zawadzki Change-Id: Id1a5358882dc496faa5b0b5c9a63b326c378c551Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/11361Tested-by: SPDK CI Jenkins Community-CI: Broadcom CI Reviewed-by: Jim Harris Reviewed-by: Ben Walker List of files: /spdk/lib/bdev/Makefile

b7ad5b0b907267bb5ecf7c5a3d48e8c2128008bb - bdev/zone: add support for get zone id

Thu, 11 Nov 2021 01:06:46 +0000

bdev/zone: add support for get zone idIn the bdev-zone API, there are a few functions that takes a zone_id:spdk_bdev_get_zone_info(), spdk_bdev_zone_management(), and thespdk_bdev_zone_append() functions.The way a zoned application is usually written is that it starts offby getting the zone report for all zones (zone_id will be sent in as 0),and then the application will keep the whole zone report in memory.Therefore, an application usually have access to the zone_id/zslba forall zones. However, there are cases, e.g. when getting an error on write,where the completion callback will only have the lba of the write thatfailed.Add a helper function that can be used to get the zone_id/slba for agiven lba. Having this helper in bdev-zone will avoid SPDK applicationsneeding to provide their own implementation for this.Signed-off-by: Niklas Cassel Change-Id: I978335f87f7d49bc33aed81afcaa6d9f0af8a1e4Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/10180Community-CI: Broadcom CI Tested-by: SPDK CI Jenkins Reviewed-by: Jim Harris Reviewed-by: Ben Walker List of files: /spdk/lib/bdev/Makefile

c3a5848966ab086e75cf67833d82d7278cc92ad6 - bdev: Add API to get SPDK memory domains used by bdev

Fri, 06 Aug 2021 05:31:02 +0000

bdev: Add API to get SPDK memory domains used by bdevChange-Id: Ic9f42eff59bdc4c8c6e73deb76b3eecfc04f80a8Signed-off-by: Alexey Marchuk Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/6268Tested-by: SPDK CI Jenkins Community-CI: Broadcom CI Community-CI: Mellanox Build BotReviewed-by: Ben Walker Reviewed-by: Shuhei Matsumoto Reviewed-by: Ziye Yang List of files: /spdk/lib/bdev/Makefile

6cebe9d06b14ad173e45d2b9be49b04f64b5fba3 - nvmf: Support physical block size if exposed by bdev

Fri, 09 Apr 2021 16:18:41 +0000

nvmf: Support physical block size if exposed by bdev(Note: this patch was previously applied as b32cfc46 and then revertedas 63642bef.)Today the in-guest nvme device shows physical_block_size=512 even thoughthe backend iSCSI bdev supports physical_block_size=4KiSCSI targets exposes physical block size usinglogical_block_per_physical_block_exponent in READ_CAPACITY_16NPWG is one of the way to let Linux nvme driver setphysical_block_size of the nvme block device.This patch adds spdk_bdev.phys_blocklen which is updated if the iSCSIbackend exposes physical_block_size.Later phys_blocklen is used in nvmf to set NPWG and NAWUPF to reportback during NS identity.Linux driver uses min(nawupf, npwg) to set physical_block_size.Similarly in scsi_bdev fill lbppbe in READ_CAP16 responsebased on spdk_bdev.phys_blocklen.Fixes #1884Signed-off-by: Swapnil Ingle Change-Id: I0b6c81f1937e346d448f49c927eda8c79d2d75c0Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/7739Community-CI: Broadcom CICommunity-CI: Mellanox Build BotTested-by: SPDK CI Jenkins Reviewed-by: Aleksey Marchuk Reviewed-by: Shuhei Matsumoto List of files: /spdk/lib/bdev/Makefile

e4070ee0e012c345f4c059f125f4f9ce3be66690 - so_ver: increase all major versions

Fri, 29 Jan 2021 10:11:25 +0000

so_ver: increase all major versionsTo allow SO_MINOR updates on LTS for the whole year it is supported,the major version for all components needs to be increased.This is to prevent scenario where two versions exists with matchingversions, but conflicting ABI.Ex. Next SPDK release adds an API call increasing the minor version,then LTS needs just a subset of those additions.Increasing major so version after LTS, allows the quarterly releasesto update versions as needed. Yet allowing LTS to increase minorversion separately.Disabled test for increasing SO version without ABI change, asthat is goal of this patch. This check shall be removed with SPDK 21.04release.This patch:- increases SO_VER by 1 for all components- resets SO_MINOR to 0 for all components- removes suppressions for ABI testsSigned-off-by: Tomasz Zawadzki Change-Id: I44d01154430a074103bd21c7084f44932e81fe72Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/6167Community-CI: Broadcom CICommunity-CI: Mellanox Build BotTested-by: SPDK CI Jenkins Reviewed-by: Ben Walker Reviewed-by: Jim Harris List of files: /spdk/lib/bdev/Makefile

da625683a63f0d42690b14408646fd9c05839ced - bdev: virtio blk read max size and segs

Mon, 12 Oct 2020 15:33:36 +0000

bdev: virtio blk read max size and segsThe backend device such as virtio-blk or virtio-scsimay support the SIZE_MAX and SEG_MAX. Then SPDK needsto split the big IO. Add this feature in bdev.Change-Id: I2442e14121ccf141682964425e96382fec482af3Signed-off-by: Jin Yu Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/4600Community-CI: Broadcom CICommunity-CI: Mellanox Build BotTested-by: SPDK CI Jenkins Reviewed-by: Changpeng Liu Reviewed-by: Shuhei Matsumoto List of files: /spdk/lib/bdev/Makefile