Changes in configure

081f8add594e2d188f285968efdeb3a02a91b32d - config: add SPDK_CONFIG_MAX_NUMA_NODES

Mon, 12 Aug 2024 22:31:33 +0000

config: add SPDK_CONFIG_MAX_NUMA_NODESBy default, to minimize impact to existing use cases, iobuf willbe configured to only support a single set of buffer pools, as it istoday. Users who want to enable support for per-NUMA node bufferpools will need to specify --max-numa-nodes parameter to theconfigure script.Signed-off-by: Jim Harris Change-Id: I8c7cd1a921e538bdb8e3af84ba27a23b5294d776Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24538Community-CI: Community CI Samsung Reviewed-by: Shuhei Matsumoto Community-CI: Broadcom CI Reviewed-by: Ben Walker Community-CI: Mellanox Build BotTested-by: SPDK CI Jenkins Reviewed-by: Konrad Sztyber List of files: /spdk/configure

ef6f8577609f639bde035a4cd59613570905c5ae - configure: clarify optional parameter for --with-rdma

Wed, 02 Oct 2024 23:07:38 +0000

configure: clarify optional parameter for --with-rdmaThe DIR was likely copied from some other option, but for --with-rdmait is a provider name, not a directory.Signed-off-by: Jim Harris Change-Id: Icd262a823db7bff144b1b3c4ebfc27196902d65fReviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/25126Community-CI: Broadcom CI Community-CI: Mellanox Build BotReviewed-by: Shuhei Matsumoto Tested-by: SPDK CI Jenkins Reviewed-by: Konrad Sztyber List of files: /spdk/configure

48b83bb7b3b1ea42dfb6709a8389c6f2ff52f405 - lib/accel: support lz4 in accel sw

Wed, 14 Aug 2024 09:39:52 +0000

lib/accel: support lz4 in accel swThe lz4 compression package performs very well and isa good choice for compression that requires performanceChange-Id: Iefb5e04722c9be9d1a09ba3b4da364795a3a44e6Signed-off-by: Yankun Li <845245370@qq.com>Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24466Reviewed-by: Konrad Sztyber Reviewed-by: Jim Harris Tested-by: SPDK CI Jenkins Community-CI: Mellanox Build BotReviewed-by: Aleksey Marchuk List of files: /spdk/configure

599480221d1f38db92e16298fd79e6473b273e8b - test/coverage: Don't reject coverage under FreeBSD

Wed, 28 Aug 2024 09:46:15 +0000

test/coverage: Don't reject coverage under FreeBSDIt's a bit awkward situation where we reject coverage for freebsdvia the configure step and yet support it in the mk.Tested coverage collection under freebsd14 using supported lcov(1.15) - seems to be working just fine.CI's end still needs to arm FreeBSD with proper tools but stagingtests look promising for now.Change-Id: Ie09a70cb894d82c1942e0b1d8d6c516a9a8b21d2Signed-off-by: Michal Berger Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24743Tested-by: SPDK CI Jenkins Community-CI: Mellanox Build BotReviewed-by: Konrad Sztyber Reviewed-by: Jim Harris List of files: /spdk/configure

e21c39aa707f29bcf6e1cb1989083b9cca3d9849 - fsdev/aio: Add aio fsdev implementation

Mon, 13 Nov 2023 15:29:17 +0000

fsdev/aio: Add aio fsdev implementationChange-Id: I5add43886241803eb3a65d64beae58ddd91d335dSigned-off-by: Anton Nayshtut Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/22534Reviewed-by: Ben Walker Community-CI: Mellanox Build BotTested-by: SPDK CI Jenkins Reviewed-by: Jim Harris List of files: /spdk/configure

bf30e09abe1667ae2769aa367cde39c550bcac00 - fsdev: Add generic filesystem layer implementation

Mon, 13 Nov 2023 15:22:44 +0000

fsdev: Add generic filesystem layer implementationChange-Id: I021b7574de0862d42a8c82b8ca4d39b816025a5bSigned-off-by: Anton Nayshtut Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/22511Community-CI: Mellanox Build BotReviewed-by: Jim Harris Tested-by: SPDK CI Jenkins Reviewed-by: Ben Walker List of files: /spdk/configure

50222f810e4127127c94652a602cf0cb18f97f60 - configure: don't exit on non Intel platforms

Mon, 15 Jul 2024 09:10:03 +0000

configure: don't exit on non Intel platformsIn order to better promote DSA to users, it is recommended to changethe error message detected by non Intel CPUs to warning. One reasonis that SPDK compilation and execution may not be on the same server.Another reason is that users may compile spdk when building Dockerimages on different platforms. This error is not conducive to directlycompiling idxd into SPDK, then build container images. Since the userhas added “--with-idxd”, we should not block this configure and compileprocess. Users need to successfully compile and run it on othermachines or containers on other machines. The check here is too strict.Although DSA hardware is not available on non Intel platforms and somelower versions of Intel CPUs, configuring it is code safe. Because theorder of running SPDK and sending instructions is after checking theDSA hardware.Change-Id: I378445449827663acad02552abb54cc737f167f0Signed-off-by: Yin Congmin Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24172Reviewed-by: Tomasz Zawadzki Community-CI: Mellanox Build BotReviewed-by: Changpeng Liu Tested-by: SPDK CI Jenkins List of files: /spdk/configure

13603217dc2e55f5a06618ad1a342df3bcb52a52 - accel/dpdk_cryptodev: Support uadk crypto pmd

Sat, 27 Apr 2024 10:40:28 +0000

accel/dpdk_cryptodev: Support uadk crypto pmdAdd support of UADK Crypto Poll Mode Driver to accel/dpdk_cryptodev.Build:./configure --with-dpdk-uadk --with-cryptomakeRun./build/bin/spdk_tgt -m 0xf0 --wait-for-rpc./scripts/rpc.py dpdk_cryptodev_scan_accel_module./scripts/rpc.py dpdk_cryptodev_set_driver -d crypto_uadk./scripts/rpc.py accel_assign_opc -o encrypt -m dpdk_cryptodev./scripts/rpc.py accel_assign_opc -o decrypt -m dpdk_cryptodev./scripts/rpc.py framework_start_initChange-Id: I73b763bdcf16c172501a3c2e785450401e8d54b2Signed-off-by: Zhangfei Gao Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/22979Community-CI: Mellanox Build BotReviewed-by: Jim Harris Tested-by: SPDK CI Jenkins Reviewed-by: Marcin Spiewak Reviewed-by: Aleksey Marchuk List of files: /spdk/configure

fc8dece06bf594cc01e52a77551b3eed0eb22304 - nvme: initial in-band authentication code

Mon, 22 Jan 2024 14:48:32 +0000

nvme: initial in-band authentication codeThis patch adds structures that will be used to implement NVMe in-bandauthentication using the DH-HMAC-CHAP protocol. They're mostly empty fornow, the following patches will implement each step of this process.The authentication is executed by exchanging several messages using theAUTHENTICATION_SEND and AUTHENTICATION_RECEIVE commands from the FabricsCommand Set. The messages sent by the host map to the SEND commands,while those sent by the controller map to the RECEIVE commands.The flow roughly consists of 5 steps: 1. The host sends a AUTH_negotiate message to listing the hash function and Diffie-Hellman group it supports. 2. The controller responds with a DH-HMAC-CHAP_challenge message selecting one of the hash functions and DH groups from those sent by the host along with a challenge value and an optional DH public key. 3. The host calculates an HMAC of the challenge (optionally augmented with a DH secret) and sends it back to the controller using a DH-HMAC-CHAP_reply message along with its DH public key. If bidirectional authentication is requested, it includes its own challenge value in that message. 4. The controller verifies the response to the challenge received from the host comparing it to its HMAC calculation. If successful, it sends a DH-HMAC-CHAP_success1 message with an optional response to the host challenge. 5. If bidirectional authentication wasn't requested, the authentication process is finished at this point. Otherwise the host verifies controller's response to the host's challenge and, if successful, sends a DH-HMAC-CHAP_success2 message.Any errors during this process are reported by sending either anAUTH_failure1 message (sent by the controller) or AUTH_failure2 (sent bythe host).Signed-off-by: Konrad Sztyber Change-Id: I84cc1574e15884e1e3d3d03e517cb38f05e12ef6Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/21981Reviewed-by: Ben Walker Reviewed-by: Jim Harris Community-CI: Mellanox Build BotTested-by: SPDK CI Jenkins List of files: /spdk/configure

6610b3e4fb6acadf7495b249cdbdbdf789757873 - module/keyring: add linux keyring module

Sat, 23 Dec 2023 16:52:52 +0000

module/keyring: add linux keyring moduleThis module uses the keyutils library to fetch keys managed by the Linuxkernel keyring. The keys are created implicitly in the probe_key()callback. For now, they need to be attached to the kernel's keyringbefore requesting them. The following patches will add the ability tospecify callout information which will allow the kernel to instantiatethe keys if they're unavailable.Change-Id: I0aedd19247c6c35f22bcb61f4b387d5d85b42cdfSigned-off-by: Konrad Sztyber Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/21760Reviewed-by: Aleksey Marchuk Reviewed-by: Jim Harris Community-CI: Mellanox Build BotTested-by: SPDK CI Jenkins List of files: /spdk/configure

d965bc4d0c2f2d8a848c68c5cc373d67b326be84 - configure: put isa-l configure logs in rootdir

Sat, 02 Mar 2024 06:07:06 +0000

configure: put isa-l configure logs in rootdirThat way, isa-l directories don't show up as having untracked files ingit after running configure.Signed-off-by: Konrad Sztyber Change-Id: Ia57720c3844823029219d20a26e68b7f0294d412Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/22122Tested-by: SPDK CI Jenkins Reviewed-by: Aleksey Marchuk Reviewed-by: Tomasz Zawadzki Reviewed-by: Michal Berger List of files: /spdk/configure

a32086ac8e6671c3d38968c94e7f1e7f1b646b41 - configure: Fix the way how cc.mk variables are read

Mon, 26 Feb 2024 13:40:25 +0000

configure: Fix the way how cc.mk variables are readThe 7a18673528 didn't consider a fact that vars like $CC can also holdan actual list of arguments to the compiler (instead of having them aspart of $CFLAGS for instance). So make sure something like:CC=gcc -Wwhatever -ffoo ...is slurped by source properly.Change-Id: I7d9a26d318bef42655a3dde127db2226c9759949Signed-off-by: Michal Berger Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/22030Community-CI: Mellanox Build BotReviewed-by: Konrad Sztyber Reviewed-by: Jim Harris Tested-by: SPDK CI Jenkins List of files: /spdk/configure

db5f3612f5b2b8740abfcaf7c2478e6d1dacebfa - build: Allow user to specify path for PGO data

Tue, 14 Nov 2023 16:59:29 +0000

build: Allow user to specify path for PGO dataThis is useful if you are building SPDK as part of a much largerapplication and you want all PGO output to go to the same place.Change-Id: I4bc4504462a1eabc3e21712a1cd06f2b6f0c4687Signed-off-by: Ben Walker Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/21959Community-CI: Mellanox Build BotTested-by: SPDK CI Jenkins Reviewed-by: Jim Harris Reviewed-by: Aleksey Marchuk List of files: /spdk/configure

d0f57d15e3a18d6a981f32fb1c8beff9c11b0bb7 - configure: Hint compiler at what linker to use via -fuse-ld

Wed, 07 Feb 2024 22:43:58 +0000

configure: Hint compiler at what linker to use via -fuse-ldWhen user provides custom $LD, which points at something different thanthe bfd linker, it's not considered while testing the dependencies viaBUILD_CMD[@]. Granted, the proper linker is then set via our mk infra,but the same way as BUILD_CMD[@] uses $CC, ${C,LD}FLAGS it should alsoconsider other relevant opts.There's a small conundrum that forces as to do the same thing for theisa-l* - in case user tries to provide extra params to the linker viaLDFLAGS and which may be specific to a given $LD_TYPE, the isa-l*configure will fail while trying to compile its dependencies. This isbecause it still slurps the LDFLAGS but the compiler keeps using thedefault linker. As we overwrite isa-l*'s CFLAGS via its cmdline wecan't pass that information through the environment as well. So as abest effort, without dancing too much, just pass -fuse-ld to it basedon what detect_cc.sh already provided. From perspective of the actualisa-l* build this is still foobar, since this param won't be actuallyused (and clang won't mind telling us about it) so to silence anywarnings about it slap no-unused-command-line-argument as well.Change-Id: If392c64099b0b50c879d504151763723924edf77Signed-off-by: Michal Berger Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/21769Tested-by: SPDK CI Jenkins Reviewed-by: Konrad Sztyber Reviewed-by: Jim Harris Community-CI: Mellanox Build Bot List of files: /spdk/configure

d3d3c0a84d3ccf5e764336d7727e8837af1a5916 - configure: Fix SHARED check for isa-l*

Thu, 08 Feb 2024 00:06:29 +0000

configure: Fix SHARED check for isa-l*Instead of checking the actual value we were just checking ifCONFIG["SHARED"] is set - it's always set as it does come witha default (n). This was causing isa-l to be always built withshared libraries.Change-Id: I2a6047f0bb6de8ac00fa10bb86ffc9ff617011d4Signed-off-by: Michal Berger Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/21768Tested-by: SPDK CI Jenkins Reviewed-by: Aleksey Marchuk Community-CI: Mellanox Build BotReviewed-by: Jim Harris List of files: /spdk/configure

7a1867352851d980abd10e15cd03b6b06a1f6ac5 - configure: Unify read of cc.mk

Wed, 07 Feb 2024 22:27:56 +0000

configure: Unify read of cc.mkTwo variables were being unnecessarily set in two different ways.Instead, just slurp entire cc.mk into the environment - this fileis generated by detect_cc.sh hence the format is known to besourceable.Change-Id: I0befe86ee59c5468cc3658bbc08b96841eea2a36Signed-off-by: Michal Berger Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/21767Reviewed-by: Konrad Sztyber Community-CI: Mellanox Build BotReviewed-by: Jim Harris Tested-by: SPDK CI Jenkins List of files: /spdk/configure

9321130701d3c92d7450596e426038872b0486bd - configure: fix missing libfuse3 error message

Wed, 17 Jan 2024 06:56:27 +0000

configure: fix missing libfuse3 error messageConfigure option is actually called "--with-nvme-cuse",not "--with-cuse".Signed-off-by: Karol Latecki Change-Id: I005690565a5938eece38631027d19f3e74c70452Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/21462Reviewed-by: Konrad Sztyber Reviewed-by: Pawel Piatek Reviewed-by: Marek Chomnicki Community-CI: Mellanox Build BotReviewed-by: Jim Harris Tested-by: SPDK CI Jenkins Reviewed-by: Michal Berger Reviewed-by: Tomasz Zawadzki List of files: /spdk/configure

6c6c42fc2dc87c380648fea365feaf7f1d88928c - isal: If the user builds with shared libraries, use ISA-L shared

Thu, 18 Jan 2024 19:48:15 +0000

isal: If the user builds with shared libraries, use ISA-L sharedlibrariesChange-Id: I6e5882a2d0347971e99bbed26a2291cb3361800bSigned-off-by: Ben Walker Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/21490Community-CI: Mellanox Build BotReviewed-by: Jim Harris Reviewed-by: Tomasz Zawadzki Tested-by: SPDK CI Jenkins List of files: /spdk/configure

b02581a89058ebaebe03bd0e16e3b58adfe406c1 - isal: If using ISA-L submodule, install it during 'make install'

Wed, 10 Jan 2024 18:26:38 +0000

isal: If using ISA-L submodule, install it during 'make install'Change-Id: I6934c3c23969bfce6365e67397147c1837b7f515Signed-off-by: Ben Walker Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/21386Reviewed-by: Tomasz Zawadzki Reviewed-by: Jim Harris Community-CI: Mellanox Build BotTested-by: SPDK CI Jenkins List of files: /spdk/configure

f14b142a05ab712165776e09d5f4444b2292470b - build: Install python libraries using pip install

Wed, 10 Jan 2024 18:10:34 +0000

build: Install python libraries using pip installThis is the modern way to do it and it is much simpler. We no longerneed --pydir for ./configure because it just uses --prefix.Fixes #3188Change-Id: I2d05c5e37fa3d1aa8cd0358ca887f8dda06bd5d7Signed-off-by: Ben Walker Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/21384Reviewed-by: Wojciech Panfil Reviewed-by: Jim Harris Tested-by: SPDK CI Jenkins Reviewed-by: Tomasz Zawadzki List of files: /spdk/configure