Changes in Makefile

66289a6dbe28217365daa40fd92dcf327871c2e8 - build: use VERSION file for storing version

Fri, 06 Dec 2024 16:51:55 +0000

build: use VERSION file for storing versionThis reduces the number of places to update whenever a version is bumpedand also gives us an easy way to check the current version from scripts.Signed-off-by: Konrad Sztyber Change-Id: I01d7240b6e07467548c211f1e505c1e1a34360afReviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/25523Community-CI: Mellanox Build BotCommunity-CI: Community CI Samsung Tested-by: SPDK CI Jenkins Reviewed-by: Ben Walker Reviewed-by: Jim Harris List of files: /spdk/Makefile

1e46e02366b3d3a0a9eba02262d4b36797bd7898 - go/rpc: Build configuration for go-rpc folder

Wed, 06 Sep 2023 15:03:11 +0000

go/rpc: Build configuration for go-rpc folderIntroduces new flags in configuration:--with-golang--without-golangChange-Id: I5783b4ddfa53fc34ef7e921a6ee2aae0f4aadd44Signed-off-by: Maciej Mis Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/19774Reviewed-by: Tomasz Zawadzki Community-CI: Mellanox Build BotReviewed-by: Konrad Sztyber Tested-by: SPDK CI Jenkins List of files: /spdk/Makefile

91c64673a2ae54bd409f08e447a4aa77e9cd5d3f - build: install python modules using setup.py

Thu, 16 Feb 2023 12:33:47 +0000

build: install python modules using setup.pyAdd Makefile to install Python spdk modules, since python modulepath depend on distribution, add `pydir` variable to allow specifycustom path.Signed-off-by: Sebastian Brzezinka Change-Id: I2a2ba50142d2804eb56a98fe092098e7f3a53fdcReviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/16950Reviewed-by: Tomasz Zawadzki Tested-by: SPDK CI Jenkins Reviewed-by: Konrad Sztyber Community-CI: Mellanox Build Bot List of files: /spdk/Makefile

784b9d48746955f210926648a0131f84f58de76f - isa-l_crypto: Add submodule

Tue, 04 Oct 2022 19:14:10 +0000

isa-l_crypto: Add submoduleAdd a new config option CONFIG_ISAL_CRYPTO whichis set if both isa-l and isa-l-crypto are enabled.This config option will be used in next patch toenable SW crypto operations in accel fwSigned-off-by: Alexey Marchuk Change-Id: I9cf6b754fb3888e21c05aa20bade21cf90d5d090Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/14857Tested-by: SPDK CI Jenkins Reviewed-by: Tomasz Zawadzki Reviewed-by: Jim Harris Reviewed-by: Paul Luse Reviewed-by: Krzysztof Karas Reviewed-by: Reviewed-by: Shuhei Matsumoto List of files: /spdk/Makefile

a6dbe3721eb3b5990707fc3e378c95e505dd8ab5 - update Intel copyright notices

Tue, 01 Nov 2022 20:26:26 +0000

update Intel copyright noticesper Intel policy to include file commit date using git cmdbelow. The policy does not apply to non-Intel (C) notices.git log --follow -C90% --format=%ad --date default | tail -1and then pull just the 4 digit year from the result.Intel copyrights were not added to files where Intel either hadno contribution ot the contribution lacked substance (ie licenseheader updates, formatting changes, etc). Contribution date used"--follow -C95%" to get the most accurate date.Note that several files in this patch didn't end the license/(c)block with a blank comment line so these were added as the vastmajority of files do have this last blank line. Simply there forconsistency.Signed-off-by: paul luse Change-Id: Id5b7ce4f658fe87132f14139ead58d6e285c04d4Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/15192Tested-by: SPDK CI Jenkins Reviewed-by: Jim Harris Reviewed-by: Ben Walker Community-CI: Mellanox Build Bot List of files: /spdk/Makefile

c996aff28d95fd7b018fb1004122e78071e4f8fd - build: move protobuf files to a top-level directory

Mon, 17 Oct 2022 09:51:22 +0000

build: move protobuf files to a top-level directoryUp until now, the protobuf files were all located under`python/spdk/sma/proto`. This was fine, as they were only used in SMAand we only generated python code. However, now, we would also like toto output code for other (e.g. go) languages too, so it no longer makesense to keep them under `python`.Only the protobuf files will be stored under `proto`. The autogeneratedpython code will remain under `python`, while the go code will be put inthe `go` directory.While here, simplified the Makefile by removing a function generatingrules based on a directory, because we keep all protobuf files in thesame location.Signed-off-by: Konrad Sztyber Change-Id: I4dcb7b33cd6f2930732f04dee62e35571b09315bReviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/15016Tested-by: SPDK CI Jenkins Reviewed-by: Tomasz Zawadzki Reviewed-by: Jim Harris Community-CI: Mellanox Build Bot List of files: /spdk/Makefile

b5689b389ec2c3b6539d0205a95be7496a46c81e - build: Make sure isa-l is built prior building dependent libs

Thu, 22 Sep 2022 10:02:25 +0000

build: Make sure isa-l is built prior building dependent libsIn case SPDK is built with --with-dpdk[=*] rather than the submoduleit starts building libs and isa-l together leading to: SO libspdk_util.so.5.1 /usr/bin/ld.bfd: cannot find -lisal collect2: error: ld returned 1 exit status make[2]: *** [/root/spdk/mk/spdk.lib.mk:86: /root/spdk/build/lib/libspdk_util.so.5.1] Error 1 make[1]: *** [/root/spdk/mk/spdk.subdirs.mk:16: util] Error 2 make: *** [/root/spdk/mk/spdk.subdirs.mk:16: lib] Error 2To avoid this make sure that isa-l, being a hard dependency now, isalways build before anything else.Signed-off-by: Michal Berger Change-Id: I933900a756924458324062cd740d99e5ccb370f6Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/14621Reviewed-by: Pawel Piatek Reviewed-by: Tomasz Zawadzki Reviewed-by: Konrad Sztyber Reviewed-by: Aleksey Marchuk Community-CI: Mellanox Build BotTested-by: SPDK CI Jenkins List of files: /spdk/Makefile

6f338d4bf3a8a91b7abe377a605a321ea2b05bf7 - bdev : xNVMe BDEV module implementation

Wed, 19 Jan 2022 10:12:50 +0000

bdev : xNVMe BDEV module implementationThis implementation of xNVMe BDEV module supports the char-device / ioctl-over-uring,along with the "regular" io_uring, libaio, POSIX aio, emulated aio (via threadpools) etc.Code changes done :a. Addition of xNVMe submodule to SPDKb. Modification of RPC scripts to Create / Delete xNVMe BDEVsc. Implementation of xNVMe BDEV moduleSigned-off-by: Krishna Kanth Reddy Change-Id: If814ca1c784124df429d283015a6570068b44f87Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/11161Reviewed-by: Aleksey Marchuk Reviewed-by: Changpeng Liu Reviewed-by: Ben Walker Reviewed-by: Jim Harris Tested-by: SPDK CI Jenkins List of files: /spdk/Makefile

488570ebd418ba07c9e69e65106dcc964f3bb41b - Replace most BSD 3-clause license text with SPDX identifier.

Fri, 03 Jun 2022 19:15:11 +0000

Replace most BSD 3-clause license text with SPDX identifier.Many open source projects have moved to using SPDX identifiersto specify license information, reducing the amount ofboilerplate code in every source file. This patch replacesthe bulk of SPDK .c, .cpp and Makefiles with the BSD-3-Clauseidentifier.Almost all of these files share the exact same license text,and this patch only modifies the files that contain themost common license text. There can be slight variationsbecause the third clause contains company names - most say"Intel Corporation", but there are instances for Nvidia,Samsung, Eideticom and even "the copyright holder".Used a bash script to automate replacement of the license textwith SPDX identifier which is checked into scripts/spdx.sh.Signed-off-by: Jim Harris Change-Id: Iaa88ab5e92ea471691dc298cfe41ebfb5d169780Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/12904Community-CI: Broadcom CI Community-CI: Mellanox Build BotTested-by: SPDK CI Jenkins Reviewed-by: Aleksey Marchuk Reviewed-by: Changpeng Liu Reviewed-by: Dong Yi Reviewed-by: Konrad Sztyber Reviewed-by: Paul Luse Reviewed-by: List of files: /spdk/Makefile

048fb36ac38d8863ae948fa1c1324105b1f04c15 - sma: initial Storage Management Agent structures

Wed, 05 Jan 2022 09:32:09 +0000

sma: initial Storage Management Agent structuresStorage Management Agent is a gRPC server that provides an abstractionlayer above the SPDK RPC interface. The interface aims to provide a setof methods for managing various protocols (e.g. NVMe, virtio-blk) whilehiding the details of a particular transport.The external API is defined by `lib/python/spdk/sma/proto/sma.proto`protobuf file. It defines the generic gRPC service methods and theirrequests/responses. Device-specific messages are defined in their ownfiles. This patch also defines messages for creating NVMe and NVMe/TCPdevices.This patch implements a gRPC service that delegates the work to aspecific device type. A DeviceManager is a class that implements someof the methods defined by the service for a given type of devices (e.g.NVMe, virtio-blk, NVMe/TCP, etc.). For now, only the RPC for creating adevice is implemented, others are added in subsequent patches.The series implements the generic calls as well as their NVMe/TCPimplementation. Support for other devce types could be easily added bycreating a new device manager and defining its protobuf parameterdefinition.Signed-off-by: Konrad Sztyber Change-Id: I17cde3b31d3514878f1027cfcd112b48848f6123Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/10273Community-CI: Broadcom CI Community-CI: Mellanox Build BotTested-by: SPDK CI Jenkins Reviewed-by: Ben Walker Reviewed-by: Jim Harris List of files: /spdk/Makefile

92e75dfc289cd3a42bac5acb43cde6362775df3b - build: remove lib/.gitignore

Thu, 12 Aug 2021 14:35:04 +0000

build: remove lib/.gitignoreThis isn't required - we already have the whole build/directory in the top level .gitignore.When we remove build/lib/.gitignore, it meansbuild/lib directory must be created somewherebefore we try to place a library there. Top-levelbuilds get this directory created automatically,but building directly from a sub-directory'sMakefile means we need to explicitly createbuild/lib. So add a mkdir -p to the LIB_Cmacro to do exactly that to cover these cases.Also simplify 'make clean' at the top level Makefile.A lot of work went in there to work around this.gitignore file that's not needed now that we'vefixed the underlying problem by getting rid ofit.Suggested-by: John Levon Signed-off-by: Jim Harris Change-Id: Ibb92ff84d8c2a9bbe3e193c84f15ef3866f07b1fReviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/9169Reviewed-by: Nick Connolly Reviewed-by: Aleksey Marchuk Reviewed-by: Changpeng Liu Reviewed-by: Tomasz Zawadzki Community-CI: Broadcom CI Community-CI: Mellanox Build BotTested-by: SPDK CI Jenkins List of files: /spdk/Makefile

7232c450f97cf925a521a60ef2561eca4b65c41a - configure: Build against installed DPDK instance

Tue, 15 Jun 2021 16:42:29 +0000

configure: Build against installed DPDK instanceInterpret bare --with-dpdk opt as user's request to find installed(provided by the distro) DPDK's libs|include files and use them duringthe build.Signed-off-by: Michal Berger Change-Id: I9da99671b95af0121194b3a6d53636b0ded71f1bReviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/8348Tested-by: SPDK CI Jenkins Community-CI: Mellanox Build BotReviewed-by: Karol Latecki Reviewed-by: Tom Nabarro Reviewed-by: Reviewed-by: Jim Harris Reviewed-by: Ben Walker List of files: /spdk/Makefile

119158cda827570dc6d19cd68d5357955f74fab2 - configure: Added --disable-apps option.

Sat, 17 Apr 2021 05:09:30 +0000

configure: Added --disable-apps option.Together with options to disable examples, tests and unit-teststhis will enable us to build SPDK without linking any executables.This is useful for packaging SPDK in applications - especiallythose using own ENV.Fixes #1877Signed-off-by: Rajarshi Chowdhury Change-Id: I0467ec497d2abe2fad40cdb4ba723a240bee46d6Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/7462Community-CI: Broadcom CICommunity-CI: Mellanox Build BotTested-by: SPDK CI Jenkins Reviewed-by: Jim Harris Reviewed-by: Tomasz Zawadzki Reviewed-by: Aleksey Marchuk List of files: /spdk/Makefile

6e2c2306f9339694074c7436b4b832c96fb49820 - build: install generated pkg-config files

Wed, 10 Feb 2021 15:28:48 +0000

build: install generated pkg-config filesSigned-off-by: Jacek Kalwas Change-Id: I191ad5e3b153fb563256eba1aa695716f66db788Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/6377Community-CI: Broadcom CITested-by: SPDK CI Jenkins Reviewed-by: Jim Harris Reviewed-by: Tomasz Zawadzki List of files: /spdk/Makefile

9854c138f7b7c1833766c3ab89bbec9516f99364 - mk: add support for mingw builds

Wed, 03 Mar 2021 09:48:43 +0000

mk: add support for mingw buildsMinGW builds require a thin layer above the standard libraries toprovide POSIX functionality that is missing on Windows. Add supportfor building this.MinGW cross builds are experimental and work is ongoing to integratethem into the CI and test environment. Including the changes at thisstage is being done to facilitate that process.The layer has been arranged in the same way as DPDK and isaccessed as an external build using ./configure --with-wpdk=.Support has also been added for using a default ./wpdk inpreparation for reaching the required level of stability.The help text for ./configure indicates that support for --with-wpdkis experimental.Further details and instructions can be found at https://wpdk.github.io.Signed-off-by: Nick Connolly Change-Id: Iff0f705789f19fb193dcb3c9090c3e90613a8d9aReviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/6589Community-CI: Broadcom CICommunity-CI: Mellanox Build BotTested-by: SPDK CI Jenkins Reviewed-by: Jim Harris Reviewed-by: Ben Walker List of files: /spdk/Makefile

79f9a7f572959b77852bb0946161a34e2c502923 - build: generate pkg-config files for SPDK

Thu, 24 Sep 2020 00:06:02 +0000

build: generate pkg-config files for SPDKUsers can now generate the necessary linker args for theirown applications using something like:PKG_CONFIG_PATH=build/lib/pkgconfig pkg-config --libs spdk_nvmeDependencies between libraries are included in the generated.pc files, so the user only needs to pass the top-level subsystemsor individual SPDK libraries they are using in their application.Modules will automatically be added to the output if the associatedlibrary is specified. For example, specifying "spdk_bdev" will includethe libraries not only for spdk_bdev, but also all of the bdev modules.Users still need to supply the -Wl,--no-as-needed or -Wl,--whole-archiveflags. They cannot be added to the .pc files without increasing the lengthof the argument string by a factor of 15x to 20x.Modify the test/external_code/hello_world Makefile to use pkg-config toensure this gets tested at some level in our autotest environment.Signed-off-by: Jim Harris Change-Id: Ie48a75f11969d5d775d514cf10bcb82d197eabfdReviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/4371Community-CI: Broadcom CITested-by: SPDK CI Jenkins Reviewed-by: Tomasz Zawadzki Reviewed-by: Shuhei Matsumoto List of files: /spdk/Makefile

b30d57cdad6d2bc75cc1e4e2ebbcebcb0d98dcfa - libvfio-user: include libvfio-user as a submodule with SPDK

Mon, 02 Nov 2020 15:32:20 +0000

libvfio-user: include libvfio-user as a submodule with SPDKAlso add a CONFIG_VFIO_USER config flag, it's enabled bydefault.Change-Id: I18b44c024a264516a60f743d5c366a4c7f7c6785Signed-off-by: Changpeng Liu Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/5000Tested-by: SPDK CI Jenkins Reviewed-by: Shuhei Matsumoto Reviewed-by: Jim Harris List of files: /spdk/Makefile

fe87dcadb788e820f538a67c0a49eb57e69bbc59 - mk: Remove the content of build/lib in "clean" target

Mon, 31 Aug 2020 14:13:34 +0000

mk: Remove the content of build/lib in "clean" targetLeaving old libraries leads to incorrectly generated libspdk.so -e.g. when we configure spdk using --with-uring and after thatusing --without-uring then libspdk_bdev_uring.so will remain inbuild/lib and will become part of spdk.so built using --without-uringChange-Id: If482e9cf323b58f3f588b7c3bdb629425ae0ceebSigned-off-by: Alexey Marchuk Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/3986Tested-by: SPDK CI Jenkins Community-CI: Broadcom CIReviewed-by: Ben Walker Reviewed-by: Tomasz Zawadzki List of files: /spdk/Makefile

6b41a08654b6c6545c099ecb66e12e3d3a1bf6e2 - dpdkbuild: build dpdk with meson+ninja

Mon, 23 Mar 2020 16:55:08 +0000

dpdkbuild: build dpdk with meson+ninjaMakefile support in DPDK was deprecated and will be removed soon,so switch to the officially supported way of building DPDK -with meson and ninja. Two new tools. Basically, our Makefileswill invoke meson+ninja for DPDK, no other SPDK components areaffected.Apparently DPDK wanted to move away from an octopus-like configsystem and the ideology behind meson configuration is simple now:build everything by default. Some PMDs can be explicitly disabledwith meson command line, but all libraries (both static and sharedversions) and test apps are built unconditionally.How long does it take to build minimal DPDK with meson? Too much.On my machine half of the total build time is spent on librarieswe don't need at all. (I have some hacks up my sleeve to disablebuilding those libraries - see the subsequent patch.) As for theofficial way of building a minimal DPDK, there was a patch [1]on dpdk mailing list to introduce more specific configuration,but it was rejected:> We talked about this a few times in the past, and it was actually one> of the design goals to _avoid_ replicating the octopus-like config> system of the makefiles. That's because it makes the test matrix> insanely complicated, not to mention the harm to user friendliness,> among other things.>> If someone doesn't want to use a PMD, they can just avoid installing it> - it's simple enough.>> Sorry, but from me it's a very strong NACK.Let's not follow that direction, hack the DPDK build system instead.As for advantages of meson+ninja over Makefiles? I can't find any.It's another build system that does a lot for you with some functions,magic options, and a built-in dependency system. It seems nice if you knowthe syntax, but it's another component that you need to learn, debug,and possibly find bugs in (there's a lot of github issues open for meson).I would compare it to CMake.As for changes in this patch: rather that explicitly disablingPMDs we don't need, specify a list of PMDs we do need and disableeverything else found in ./dpdk/drivers/*. This way we won't haveto disable the new PMDs as they're added to DPDK.Meson configuration also sets RTE_EAL_PMD_PATH #define to a valid directorywith built PMD shared libs. When it's set, DPDK dynamically loads all sharedlibraries inside. The drivers there depend on DPDK shared libs and fail toload in static SPDK builds, so we disable them altogether by unsettingRTE_EAL_PMD_PATH in the meson-generated config file - just likeDPDK Makefiles did. EAL checks for RTE_EAL_PMD_PATH being empty and skipsloading any external PMDs then. We do it for both static and shared libs.We specify all PMDs at build time for now, so there's just no need to loadthem dynamically.We have three more hacks in our submodule: * disable building dpdk apps by commenting-out a line in dpdk/meson.build * disable building unnecessary libs (build everything that spdk *may* need) * build isa-l compress pmd with `-L[...] -lisal`. DPDK expects to find libisal with pkg-config. We don't want to prepare a pkg-config file, so comment-out a failing check in another meson.build file and provide isa-l through CFLAGS and LDFLAGS.We also need to make some changes to our test/external_code. First ofall, -ldpdk is no more. Meson build generates a pkg-config file with alllibs, but we'll switch to it in a separate patch - for now just specifyall -lrte_ libs one by one. -Wl,--no-as-needed has to be added to sometest cases, otherwise rte_mempool_ring isn't loaded. We don't use anyAPIs from this library, it only has a static constructor that providesa few callbacks used by rte_mempool_create(). Also, since DPDK now buildsboth static and shared libraries, we need to add -Wl,-Bstatic to forceusing static libswhere required. It's only needed for DPDK libs, but weuse it for SPDK libs as well since there's no harm.As for performance:$ ./configure --enable-debug --with-crypto --with-reduce$ time make -j40 -C dpdkbuild allwith meson:real 0m8.287suser 1m7.983ssys 0m10.548sbefore, with the old DPDK makefiles:real 0m20.232suser 0m55.921ssys 0m16.491sThe subsequent builds are much faster too:$ time make -j40 -C dpdkbuild allmeson:real 0m0.876suser 0m0.663ssys 0m0.217smakefiles:real 0m10.150suser 0m11.740ssys 0m6.772s[1] http://inbox.dpdk.org/dev/1a07d1cd59d84dce84e56c10fdabf5e5504560a6.camel@debian.org/Change-Id: Ic65db563014100bafb12e61ee0530cc2ae64401dSigned-off-by: Darek Stojaczyk Signed-off-by: Tomasz Zawadzki Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/1440Community-CI: Mellanox Build BotTested-by: SPDK CI Jenkins Reviewed-by: Ben Walker Reviewed-by: Jim Harris List of files: /spdk/Makefile

3352b2a7b1c2d1c5994150f48f7e81c1ee2b1cc8 - build: Copy headers to build/include on build

Mon, 11 May 2020 22:36:18 +0000

build: Copy headers to build/include on buildFor completeness, now all output is placed into build/ in theappropriate location. In the future, 'make install' can be changedto simply copy from there instead of rebuilding.Signed-off-by: Ben Walker Change-Id: I236b37868b5f4a2d5c5b910090aeaa9dff0501e2Signed-off-by: Ben Walker Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/2381Community-CI: Mellanox Build BotCommunity-CI: Broadcom CITested-by: SPDK CI Jenkins Reviewed-by: Paul Luse Reviewed-by: Darek Stojaczyk Reviewed-by: Jim Harris List of files: /spdk/Makefile