en Copyright 2015 Java http://src.rcs.uwaterloo.ca:8080/history/netbsd-src/tests/usr.sbin/inetd/Makefile#4b4138ec28602f79e4f964949175cc148cb9413b fix warnings List of files: /netbsd-src/tests/usr.sbin/inetd/Makefile Wed, 01 Sep 2021 06:12:50 +0000 christos <christos@NetBSD.org> http://src.rcs.uwaterloo.ca:8080/history/netbsd-src/tests/usr.sbin/inetd/Makefile#2557380693fe72f9b9a554a68affc1b669017f0b Inetd enhancements by James Browning, Gabe Coffland, Alex Gavin, Solomon RitzowDescribed in: https://www.mail-archive.com/tech-userlevel@netbsd.org/msg03114.htmlAnd developed in: https://github.com/ritzow/src/pull/1From their notes:All new functionality should be explained by the updated manpage.The manpage has been refactored a bit: A new section "Directives"has been added and the information about default hostnames andIPsec directives has been moved there, and the new file includedirective information is also there.getconfigent has the most major changes. A newline is no longerread immediately, but is called only by a "goto more" (inside anif(false) block). This allows multiple definitions or directivesto exist on a single line for anything that doesn't terminate usinga newline. This means a key-values service definition can be followedby another key-values service definition, a positional definition,or an ipsec, hostname, or .include directive on the same line.memset is no longer used explicitly to clear the servtab structure,a function init_servtab() is used instead, which uses a C structinitializer.The servtab se_group field is its own allocation now, and not justa pointer into the user:group string.Refactored some stuff out of getconfigent to separate functionsfor use by parse_v2.c. These functions in inetd.c are named withthe form parse_*()parse_v2.c only has code for parsing a key-values service definitioninto a provided servtab. It should not have anything that affectsglobal state other than line and line_number.Some function prototypes, structures, and #defines have been movedfrom inetd.c to inetd.h.The function config_root replaces config as the function called ona config file load/reload. The code removed from the end ofconfig(void) is now called in config_root, so it is not run on eachrecursive config call.setconfig(void) was removed and its code added into config_rootbecause that is the only place it is called, and redundant checksfor non-null globals were removed because they are always freed byendconfig. The fseek code was also removed because the config filesare always closed by endconfig.Rate limiting code was updated to add a per-service per-IP ratelimiting form. Some of that code was refactored out of other placesinto functions with names in the form rl_*()We have not added any of the license or version information to thenew files parse_v2.c, parse_v2.h, and inetd.h and we have notupdated the license or version info for inetd.c.Security related:The behavior when reading invalid IPsec strings has changed. Inetdno longer exits, it quits reading the current config file instead.Could this impact program security?We have not checked for memory leaks. Solomon tried to use dmallocwithout success. getconfigent seemed to have a memory leak at each"goto more". It seems like inetd has never free'd allocated stringswhen throwing away erroneous service definitions during parsing(i.e. when "goto more" is called when parsing fields). OpenBSD'sversion calls freeconfig on "goto more"(https://github.com/openbsd/src/blob/c5eae130d6c937080c3d30d124e8c8b86db7d625/usr.sbin/inetd/inetd.c#L1049)but NetBSD only calls it when service definitions are no longerneeded. This has been fixed. freeconfig is called immediately beforeany "goto more". There shouldn't be any time when a servtab is inan invalid state where freeconfig would break. List of files: /netbsd-src/tests/usr.sbin/inetd/Makefile Sun, 29 Aug 2021 09:54:18 +0000 christos <christos@NetBSD.org>