Changes in vhost

15677ca2c751b3be2f02429bb006d859dccae0c0 - vhost: add logging mechanism for reconnection

Mon, 23 Sep 2024 19:00:00 +0000

vhost: add logging mechanism for reconnectionThis patch introduces a way for backend to keep trackof the needed information to be able to reconnect withoutfrontend cooperation.It will be used for VDUSE, which does not provide interfacefor the backend to save and later recover local virtqueuesmetadata needed to reconnect.Vhost-user support could also be added for improved packedring reconnection support.Signed-off-by: Maxime Coquelin Reviewed-by: Chenbo Xia Reviewed-by: David Marchand List of files: /dpdk/lib/vhost/vhost.c/dpdk/lib/vhost/vhost.h/dpdk/lib/vhost/virtio_net_ctrl.c

99a2dd955fba6e4cc23b77d590a033650ced9c45 - lib: remove librte_ prefix from directory names

Tue, 20 Apr 2021 10:00:00 +0000

lib: remove librte_ prefix from directory namesThere is no reason for the DPDK libraries to all have 'librte_' prefix onthe directory names. This prefix makes the directory names longer and alsomakes it awkward to add features referring to individual libraries in thebuild - should the lib names be specified with or without the prefix.Therefore, we can just remove the library prefix and use the library'sunique name as the directory name, i.e. 'eal' rather than 'librte_eal'Signed-off-by: Bruce Richardson List of files: /dpdk/lib/vhost/virtio_crypto.h

6d7e741be18ab1e6ecce46edb2516318305c3c73 - vhost: improve RARP handling in dequeue paths

Thu, 16 Jan 2025 09:00:00 +0000

vhost: improve RARP handling in dequeue pathsWith previous refactoring, we can now simplify the RARPpacket injection handling in both the sync and asyncdequeue paths.Signed-off-by: Maxime Coquelin Reviewed-by: David Marchand Reviewed-by: Chenbo Xia List of files: /dpdk/lib/vhost/virtio_net.c

474f4d7840ad4a485558aa376f756c7fa2cefac6 - vhost: add control virtqueue

Thu, 25 May 2023 16:00:00 +0000

vhost: add control virtqueueIn order to support multi-queue with VDUSE, havingcontrol queue support is required.This patch adds control queue implementation, it will beused later when adding VDUSE support. Only split ringlayout is supported for now, packed ring support will beadded later.Signed-off-by: Maxime Coquelin Reviewed-by: Chenbo Xia Acked-by: David Marchand List of files: /dpdk/lib/vhost/virtio_net_ctrl.h

fba9875559906e04eaeb74532f4cfd51194259a2 - lib: replace packed attributes

Fri, 10 Jan 2025 22:00:00 +0000

lib: replace packed attributesMSVC struct packing is not compatible with GCC. Replace macro__rte_packed with __rte_packed_begin to push existing pack valueand set packing to 1-byte and macro __rte_packed_end to restorethe pack value prior to the push.Macro __rte_packed_end is deliberately utilized to trigger aMSVC compiler warning if no existing packing has been pushed allowingeasy identification of locations where the __rte_packed_begin ismissing.Signed-off-by: Andre Muezerie List of files: /dpdk/lib/vhost/vhost_user.h

1846fe767f00a9d0dade333e7838f81e6721b694 - vhost: clear ring addresses when getting vring base

Wed, 27 Nov 2024 02:00:00 +0000

vhost: clear ring addresses when getting vring baseClear ring addresses during vring base retrieval to handle guest rebootscenarios correctly. This is particularly important for vdpa-blk deviceswhere the following issue occurs:When a guest OS with vdpa-blk device reboots, during UEFI stage, onlyone vring is actually used and configured. However, QEMU still sendsenable messages for all configured queues. The remaining queues retaintheir addresses from before reboot, which reference invalid memorymappings in the rebooted guest.The issue manifests in vq_is_ready():static boolvq_is_ready(struct virtio_net *dev, struct vhost_virtqueue *vq){ /* Only checks pointer validity, not address freshness */ rings_ok = vq->desc && vq->avail && vq->used; ...}vq_is_ready() incorrectly considers these queues as ready because itonly checks if desc/avail/used pointers are non-NULL, but cannotdetect that these addresses are stale from the previous boot.Clear the ring addresses in vhost_user_get_vring_base() to forcethe guest driver to reconfigure them before use. This ensures thatvq_is_ready() will return false for queues with stale addressesuntil they are properly reconfigured by the guest driver.Fixes: 3ea7052f4b1b ("vhost: postpone rings addresses translation")Cc: stable@dpdk.orgSigned-off-by: Jianping Zhao Reviewed-by: Maxime Coquelin List of files: /dpdk/lib/vhost/vhost_user.c

c6552d9a8deffa448de2d5e2e726f50508c1efd2 - lib: move alignment attribute on types for MSVC

Mon, 04 Mar 2024 17:00:00 +0000

lib: move alignment attribute on types for MSVCThe current location used for __rte_aligned(a) for alignment of typesis not compatible with MSVC. There is only a single location acceptedby both toolchains.The standard offers no alignment facility that compatibly interoperateswith C and C++ but it may be achieved by relocating the placement of__rte_aligned(a) to the aforementioned location accepted by all currentlysupported toolchains.To allow alignment for both compilers, do the following:* Expand __rte_aligned(a) to __declspec(align(a)) when building with MSVC.* Move __rte_aligned from the end of {struct,union} definitions to be between {struct,union} and tag.The placement between {struct,union} and the tag allows the desiredalignment to be imparted on the type regardless of the toolchain beingused for all of GCC, LLVM, MSVC compilers building both C and C++.Note: this move has an additional benefit as Doxygen is not confusedanymore like for the rte_event_vector struct definition.Signed-off-by: Tyler Retzlaff Acked-by: Morten Brørup Acked-by: Bruce Richardson Acked-by: Konstantin Ananyev Acked-by: Chengwen Feng Reviewed-by: Maxime Coquelin Signed-off-by: David Marchand List of files: /dpdk/lib/vhost/vhost_crypto.c

4025e36fa5b7e44df07d53f8e7ddfeab5f1512a2 - vhost: revert VDUSE uAPI header

Sun, 17 Nov 2024 17:00:00 +0000

vhost: revert VDUSE uAPI headerThe file vduse.h does not have a license that is compatiblewith current DPDK license policy.This reverts commit b212c2fc2cd6 ("uapi: import VDUSE header")and commit 9fec3f056908 ("vhost: use imported VDUSE uAPI header")Signed-off-by: Stephen Hemminger Acked-by: Maxime Coquelin List of files: /dpdk/lib/vhost/vduse.c/dpdk/lib/vhost/vduse.h

d8381a8f54cdc789c4260efefb5a17b9612f417e - vhost: promote max queue setting API to stable

Wed, 09 Oct 2024 13:00:00 +0000

vhost: promote max queue setting API to stableThis patch promotes the rte_vhost_driver_set_max_queue_numAPI to stable.Signed-off-by: Maxime Coquelin Acked-by: Stephen Hemminger Reviewed-by: Chenbo Xia List of files: /dpdk/lib/vhost/rte_vhost.h/dpdk/lib/vhost/version.map

719834a6849e1daf4a70ff7742bbcc3ae7e25607 - use C linkage where appropriate in headers

Fri, 20 Sep 2024 10:00:00 +0000

use C linkage where appropriate in headersAssure that 'extern "C" { /../ }' do not cover files included from aparticular header file, and address minor issues resulting from thischange of order.Dealing with C++ should delegate to the individual include file level,rather than being imposed by the user of that file. For example,forcing C linkage prevents __Generic macros being replaced withoverloaded static inline functions in C++ translation units.Eliminate 'extern "C"' from files which do not declare any symbols(e.g., only macros or struct types).On the other hand, the headers check is too naive in assuming that allheaders must contain a 'extern "C"'. Such a check was added in commit1ee492bdc4ff ("buildtools/chkincs: check missing C++ guards").Since this current change results in many headers not containing sucha token, remove the check for 'extern "C"' until we have a betterimplementation.Signed-off-by: Mattias Rönnblom Acked-by: Morten Brørup Signed-off-by: David Marchand List of files: /dpdk/lib/vhost/rte_vhost_crypto.h/dpdk/lib/vhost/vdpa_driver.h

85dbfcb1be49e512fde5c7455f9872158421ca66 - vhost: remove internal symbol from vDPA public header

Tue, 15 Oct 2024 14:00:00 +0000

vhost: remove internal symbol from vDPA public headerrte_vdpa_relay_vring_used() is an internal symbol which was left behindin the application header when doing the application vs driver APIsplit.Fixes: a49f758d1170 ("vhost: split vDPA header file")Signed-off-by: David Marchand Reviewed-by: Maxime Coquelin List of files: /dpdk/lib/vhost/rte_vdpa.h

4d2aa150769b170e439b4ae6200463140cb44ff5 - vhost: remove check around mutex init

Tue, 14 Jan 2025 07:00:00 +0000

vhost: remove check around mutex initpthread_mutex_init always returns 0. The other mutex functionsreturn 0 on success and a non-zero error code on error.Link: https://man7.org/linux/man-pages/man3/pthread_mutex_lock.3.htmlBugzilla ID: 1586Signed-off-by: Ariel Otilibili Acked-by: Stephen Hemminger Reviewed-by: Maxime Coquelin List of files: /dpdk/lib/vhost/socket.c

b3f923fe1710e448c073f03aad2c087ffb6c7a5c - vdpa: update used flags in used ring relay

Wed, 17 Jul 2024 03:00:00 +0000

vdpa: update used flags in used ring relayThe vDPA device will work incorrectly if flags such asVRING_USED_F_NO_NOTIFY are not updated correctly.Fixes: b13ad2decc83 ("vhost: provide helpers for virtio ring relay")Cc: stable@dpdk.orgSigned-off-by: Bill Xiang Reviewed-by: Maxime Coquelin List of files: /dpdk/lib/vhost/vdpa.c