Lines Matching +full:pull +full:- +full:requests
4 LLVM Code-Review Policy and Practices
7 LLVM's code-review policy and practices help maintain high code quality across
15 It is important for all contributors to understand our code-review
16 practices and participate in the code-review process.
22 -----------------------------
28 -----------------------------------------------
33 likely-community-consensus requirements (as apply to all patch approvals) can
38 responsible for making all necessary review-related changes, including
39 those requested during any post-commit review.
44 -------------------------------------------
46 Post-commit review is encouraged, and can be accomplished using any of the
48 promptly to post-commit feedback and address it. Failure to do so is cause for
53 pre-commit review (including around the need for more design discussions),
58 this is inherent to our post-commit review practices.
61 essentially as-is once concerns have been resolved.
69 Please note: The bar for post-commit feedback is not higher than for pre-commit
72 pre-commit (had you noticed it earlier), please feel free to provide that
81 ------------------------------------
83 Pre-commit code reviews are conducted on GitHub with Pull Requests. See
84 :ref:`GitHub <github-reviews>` documentation.
87 ------------------------
90 change the LLVM Language Reference (e.g., adding new target-independent
98 Code-Review Workflow
107 If you are using a Pull Request for purposes other than review
108 (eg: precommit CI results, convenient web-based reverts, etc)
109 `skip-precommit-approval <https://github.com/llvm/llvm-project/labels?q=skip-precommit-approval>`_
113 ---------------------------------
120 that when providing the updated patch. When using the web-based code-review
130 press `Re-request review <https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/requesting-a-pull-request-review#:~:text=After%20your%20pull%20request%20is%20reviewed>`_
131 to bring the Pull Request to the reviewers' attention.
134 --------------------------------------------
147 LGTM - How a Patch Is Accepted
148 ------------------------------
154 Only approval from a single reviewer is required, unless the pull request
179 If it is likely that others will want to review a recently-posted patch,
184 certainly considered polite for non-trivial patches). Especially given the
198 Splitting Requests and Conditional Acceptance
199 ---------------------------------------------
203 conditioned on the author providing a follow-up patch addressing some
210 ------------------------------------
221 Non-Experts Should Review Code
222 ------------------------------
227 remember that it is not in the long-term best interest of the community to have
244 --------------------------
252 ------------------------------------