dif: Add SPDK_DIF_FLAGS_NVME_PRACT for dif_generate/verify_copy()

Add a macro constant SPDK_DIF_FLAGS_NVME_PRACT which is the same value
as the PRACT bit in the NVMe specification.

spdk_dif_generat

dif: Add SPDK_DIF_FLAGS_NVME_PRACT for dif_generate/verify_copy()

Add a macro constant SPDK_DIF_FLAGS_NVME_PRACT which is the same value
as the PRACT bit in the NVMe specification.

spdk_dif_generate/verify_copy() works if NVME_PRACT is not set or
metadata size is equal with PI size, or return -ENOTSUP otherwise.

The following patch will support the ENOTSUP cases.

Signed-off-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Change-Id: Ie0113521572aa405f26c8c197f5ffb14ca0503ff
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/23687
Reviewed-by: Jim Harris <jim.harris@nvidia.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Community-CI: Community CI Samsung <spdk.community.ci.samsung@gmail.com>
Community-CI: Mellanox Build Bot

show more ...

dif: Insert abstraction into dif_generate/verify_copy() for NVMe PRACT

This will simplify the following changes.

Signed-off-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Change-Id: Ia3b8ffb38dd6858a

dif: Insert abstraction into dif_generate/verify_copy() for NVMe PRACT

This will simplify the following changes.

Signed-off-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Change-Id: Ia3b8ffb38dd6858a0f16b6da52a993da47c6ca4b
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/23686
Reviewed-by: Jim Harris <jim.harris@nvidia.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Community-CI: Community CI Samsung <spdk.community.ci.samsung@gmail.com>
Community-CI: Mellanox Build Bot

show more ...

dif: Rename internal generate/verify_copy() by insert/strip_copy()

We want to add NVMe PRACT handling into the DIF library.
If metadata size is equal with PI size, NVMe PRACT and insert/strip
are sa

dif: Rename internal generate/verify_copy() by insert/strip_copy()

We want to add NVMe PRACT handling into the DIF library.
If metadata size is equal with PI size, NVMe PRACT and insert/strip
are same. But, if metadata size is larger than PI size, NVMe PRACT
is overwrite/verify. Current generate/verify_copy() support only
insert/strip.

Hence, as a preparation, rename internal dif_generate/verify_copy()
by dif_insert/strip_copy().

Signed-off-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Change-Id: Ic309d8bc41e5d92ad87cacf69909f15303c2cea1
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/23685
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Community CI Samsung <spdk.community.ci.samsung@gmail.com>
Community-CI: Mellanox Build Bot
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Reviewed-by: Jim Harris <jim.harris@nvidia.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>

show more ...

vhost_blk: return VIRTIO_BLK_S_UNSUPP for flush command

SPDK vhost-blk doesn't negociate `VIRTIO_BLK_F_FLUSH` nor
`VIRTIO_BLK_F_CONFIG_WCE` feature bits, but we can still
receive FLUSH commands from

vhost_blk: return VIRTIO_BLK_S_UNSUPP for flush command

SPDK vhost-blk doesn't negociate `VIRTIO_BLK_F_FLUSH` nor
`VIRTIO_BLK_F_CONFIG_WCE` feature bits, but we can still
receive FLUSH commands from VM, here we return correct
errno for these commands in case the backend block device
doesn't support it.

Partly fix issue #3572.

Change-Id: Ib6269818ae94b38bebed3603fa8b87e97d7e7ab1
Signed-off-by: Changpeng Liu <changpeliu@tencent.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/25435
Community-CI: Community CI Samsung <spdk.community.ci.samsung@gmail.com>
Reviewed-by: Jim Harris <jim.harris@nvidia.com>
Community-CI: Mellanox Build Bot
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Reviewed-by: GangCao <gang.cao@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

dpdk: add adjustments for recent rte_power changes

There were a couple of changes to the rte_power library:
1) Hardware-specific code was moved out of rte_ower into individual
drivers under the

dpdk: add adjustments for recent rte_power changes

There were a couple of changes to the rte_power library:
1) Hardware-specific code was moved out of rte_ower into individual
drivers under the drivers/power directory.
2) The header file was renamed rte_power.h -> rte_power_cpufreq.h.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: Iac8aeb99423a21905a8bea744ccf662539b26da0
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/25424
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Michal Berger <michal.berger@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <jim.harris@nvidia.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Community-CI: Community CI Samsung <spdk.community.ci.samsung@gmail.com>

show more ...

bdev: fix per_channel data null when bdev_get_iostat with reset option

When bdev_get_iostat comes with the reset option, we should reset the
channel or bdev's stat memory area, not that stat memory

bdev: fix per_channel data null when bdev_get_iostat with reset option

When bdev_get_iostat comes with the reset option, we should reset the
channel or bdev's stat memory area, not that stat memory area
temporarily allocated for rpc output.

Fixes: 63e0c25d ("bdev: add reset_mode to bdev_get_iostat")
Change-Id: I32caaca48c84600b6c3c403ae647d6d3ce6cd5ae
Signed-off-by: Yao Liu <liuy35@chinatelecom.cn>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/25441
Community-CI: Mellanox Build Bot
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Reviewed-by: GangCao <gang.cao@intel.com>
Community-CI: Community CI Samsung <spdk.community.ci.samsung@gmail.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Changpeng Liu <changpeliu@tencent.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>

show more ...

lib/reduce: fix the magic number of empty mapping detection.

In debug mode, when the backing dev capacity is greater than 16TB, the value of io_unit_index is likely to be UINT32_MAX. Similarly, when

lib/reduce: fix the magic number of empty mapping detection.

In debug mode, when the backing dev capacity is greater than 16TB, the value of io_unit_index is likely to be UINT32_MAX. Similarly, when the capacity is greater than 64TB, the value of chunk_map_index may be UINT32_MAX.
These above situations may cause coredump to be triggered incorrectly.

Change-Id: I9d89102531daebd779b3f0eb6386f478bfcaa80b
Signed-off-by: Yalong Wang <yalong9@staff.sina.com.cn>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/25427
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Reviewed-by: GangCao <gang.cao@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Changpeng Liu <changpeliu@tencent.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Community CI Samsung <spdk.community.ci.samsung@gmail.com>
Reviewed-by: Jim Harris <jim.harris@nvidia.com>

show more ...

bdev: remove bdev from examine allow list on unregister

Removes the Bdev from the examine allow list on unregister to enable
re-registration of a Bdev with the same name.

Change-Id: Iefcb5ff8addd78

bdev: remove bdev from examine allow list on unregister

Removes the Bdev from the examine allow list on unregister to enable
re-registration of a Bdev with the same name.

Change-Id: Iefcb5ff8addd7859df56f1f2a3ce3cc309fde528
Signed-off-by: Ed Reed <edreed@microsoft.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/25426
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Community-CI: Community CI Samsung <spdk.community.ci.samsung@gmail.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Reviewed-by: Jim Harris <jim.harris@nvidia.com>

show more ...

bdev: fix a race between reset start and complete

There is a race between reset start and complete:

1. reset_1 is completing. It clears bdev->internal.reset_in_progress and
sends unfreeze_channe

bdev: fix a race between reset start and complete

There is a race between reset start and complete:

1. reset_1 is completing. It clears bdev->internal.reset_in_progress and
sends unfreeze_channel messages to remove queued resets of all
channels.
2. reset_2 is starting. As bdev->internal.reset_in_progress has been
cleared, it is inserted to queued_resets list and starts to freeze
channels.
3. reset_1's unfreeze_channel message removes reset_2 from queued_resets
list.
4. reset_2 finishes freezing channels, but the corresponding bdev_io has
gone, hence resulting in segmentation fault.

To fix this, we use per-bdev queued_resets list instead of per-channel
ones, and nullify bdev->internal.reset_in_progress after unfreezing bdev
channels. In this way, we can assure that all resets submitted during an
in-progress reset can be queued and completed correctly.

Besides, we do not insert the reset that is submitted to the underlying
device into the queued_resets list, so that the list can be processsed
cleanly.

Change-Id: I7cb14d790c1e20cea86e4829555d04acc408ee28
Signed-off-by: Jinlong Chen <chenjinlong.cjl@alibaba-inc.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/25371
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Community-CI: Community CI Samsung <spdk.community.ci.samsung@gmail.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Reviewed-by: GangCao <gang.cao@intel.com>

show more ...

nvmf/fc: Qpair disconnect callback: Serialize FC delete connection & close qpair process

An invalid pointer access can happen with KATO and FC delete
connection running parallelly. This is a

nvmf/fc: Qpair disconnect callback: Serialize FC delete connection & close qpair process

An invalid pointer access can happen with KATO and FC delete
connection running parallelly. This is a regression that got
introduced when the qpair disconnect callback was removed.

Change-Id: I8cf4ca3c3d91797e44c501e09222f503e00db4be
Signed-off-by: Kalyan Kadiyala <kalyan.kadiyala@broadcom.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/25421
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Community-CI: Community CI Samsung <spdk.community.ci.samsung@gmail.com>

show more ...

nvmf/fc: Validate the ctrlr pointer inside nvmf_fc_req_bdev_abort()

An abort request can come in for a fabric connect command before
the ctrlr is initialized. In such a case, accessing the c

nvmf/fc: Validate the ctrlr pointer inside nvmf_fc_req_bdev_abort()

An abort request can come in for a fabric connect command before
the ctrlr is initialized. In such a case, accessing the ctrlr
pointer without validating it can lead to app crash.

Change-Id: I61b79147330e566d4393a72c6a07d0dd6e032e80
Signed-off-by: Kalyan Kadiyala <kalyan.kadiyala@broadcom.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/25420
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Community-CI: Mellanox Build Bot
Community-CI: Community CI Samsung <spdk.community.ci.samsung@gmail.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

correct kick for CQ full case

We implement basic flow control by not processing any submissions while
the CQ is full. However, in interrupt mode, the code was mistakenly
attempting to kick ctrlr->in

correct kick for CQ full case

We implement basic flow control by not processing any submissions while
the CQ is full. However, in interrupt mode, the code was mistakenly
attempting to kick ctrlr->intr_fd - this will not go well, as this is
the vfio-user socket fd, not an eventfd. It should be kicking the SQ
group's eventfd.

Fixes: 23b518a0 ("nvmf/vfio_user: mitigate cq full race")
Signed-off-by: John Levon <john.levon@nutanix.com>
Change-Id: Ia3b5ad8ffe4118a620fc3894e40fc95c251cd009
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/25401
Reviewed-by: Changpeng Liu <changpeliu@tencent.com>
Community-CI: Mellanox Build Bot
Community-CI: Community CI Samsung <spdk.community.ci.samsung@gmail.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>

show more ...

lib/nvmf: clean up MSI-X BAR defines

Use the standard prefix, and add defines for the MSI-X BIR registers.

Signed-off-by: John Levon <john.levon@nutanix.com>
Change-Id: Ifb671259eb023cf9d606e03ce8b

lib/nvmf: clean up MSI-X BAR defines

Use the standard prefix, and add defines for the MSI-X BIR registers.

Signed-off-by: John Levon <john.levon@nutanix.com>
Change-Id: Ifb671259eb023cf9d606e03ce8b99d282d1bccf6
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/25365
Reviewed-by: Changpeng Liu <changpeliu@tencent.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Community-CI: Community CI Samsung <spdk.community.ci.samsung@gmail.com>

show more ...

lib/vhost: use RB_TREE for vhost device management

This is helpful when creating and starting many vhost
devices at the same time, there are lots of lookups
when starting a vhost device.

Change-Id:

lib/vhost: use RB_TREE for vhost device management

This is helpful when creating and starting many vhost
devices at the same time, there are lots of lookups
when starting a vhost device.

Change-Id: I3d395c569b6bab1c2c5c2f42d846dcf6f7d133f3
Signed-off-by: Changpeng Liu <changpeliu@tencent.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/25402
Reviewed-by: GangCao <gang.cao@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Community-CI: Community CI Samsung <spdk.community.ci.samsung@gmail.com>
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Community-CI: Mellanox Build Bot

show more ...

lib/reduce: Use memset instead of memcpy setting 0

Change-Id: I5b03513f64ea2b1abe968b6f7564f51b93099879
Signed-off-by: Yankun Li <yankun@staff.sina.com>
Reviewed-on: https://review.spdk.io/gerrit/c/

lib/reduce: Use memset instead of memcpy setting 0

Change-Id: I5b03513f64ea2b1abe968b6f7564f51b93099879
Signed-off-by: Yankun Li <yankun@staff.sina.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/25411
Reviewed-by: GangCao <gang.cao@intel.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Changpeng Liu <changpeliu@tencent.com>
Community-CI: Community CI Samsung <spdk.community.ci.samsung@gmail.com>

show more ...

lib/rdma_provider: Add API to check if accel seq supported

verbs provider doesn't support accel sequence
mlx5_dv provider supports accel sequence if a module
which implements UMR is registered, i.e.

lib/rdma_provider: Add API to check if accel seq supported

verbs provider doesn't support accel sequence
mlx5_dv provider supports accel sequence if a module
which implements UMR is registered, i.e. accel_mlx5 driver
is registered

Signed-off-by: Alexey Marchuk <alexeymar@nvidia.com>
Change-Id: I59944aceb22661f9de3198ecd571b1a73af28584
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24701
Community-CI: Mellanox Build Bot
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Community-CI: Community CI Samsung <spdk.community.ci.samsung@gmail.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>

show more ...

lib/mlx5: Add API to check if UMR registration supported

The 2 new APIs are used for negotiation between different
modules to use accel sequence/UMR

Signed-off-by: Alexey Marchuk <alexeymar@nvidia.

lib/mlx5: Add API to check if UMR registration supported

The 2 new APIs are used for negotiation between different
modules to use accel sequence/UMR

Signed-off-by: Alexey Marchuk <alexeymar@nvidia.com>
Change-Id: Ifca6a3e3a7649e48392785d7a977e1b468dbf4be
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24700
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Community-CI: Community CI Samsung <spdk.community.ci.samsung@gmail.com>
Community-CI: Mellanox Build Bot

show more ...

nvme/nvme: Factor out submit_request function

Move part of code to another function which
will later be called from several places

Signed-off-by: Alexey Marchuk <alexeymar@nvidia.com>
Change-Id: I2

nvme/nvme: Factor out submit_request function

Move part of code to another function which
will later be called from several places

Signed-off-by: Alexey Marchuk <alexeymar@nvidia.com>
Change-Id: I22b650034b505c9e65b7ec5ea1621a70dc15c576
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/25064
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Ben Walker <ben@nvidia.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Community-CI: Community CI Samsung <spdk.community.ci.samsung@gmail.com>

show more ...

nvme/rdma: Remove qpair::max_recv_sge as unused

Signed-off-by: Alexey Marchuk <alexeymar@nvidia.com>
Change-Id: I92cb54e92e93ffccc9bfaa42deab30a5433d336f
Reviewed-on: https://review.spdk.io/gerrit/c

nvme/rdma: Remove qpair::max_recv_sge as unused

Signed-off-by: Alexey Marchuk <alexeymar@nvidia.com>
Change-Id: I92cb54e92e93ffccc9bfaa42deab30a5433d336f
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24696
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Community CI Samsung <spdk.community.ci.samsung@gmail.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Ben Walker <ben@nvidia.com>

show more ...

nvme/rdma: Add likely/unlikely to IO path

Even though compilers can inline function
implicitly, let's add inline keyword to some functions
which are part of IO path.

Signed-off-by: Alexey Marchuk <

nvme/rdma: Add likely/unlikely to IO path

Even though compilers can inline function
implicitly, let's add inline keyword to some functions
which are part of IO path.

Signed-off-by: Alexey Marchuk <alexeymar@nvidia.com>
Change-Id: I54aa24607028dabd70084193b1947049c379f0d9
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24695
Reviewed-by: Ben Walker <ben@nvidia.com>
Community-CI: Community CI Samsung <spdk.community.ci.samsung@gmail.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>

show more ...

nvme/rdma: Factor our contig request preparation

Move the NVMF configuration to dedicated functions, they
are to be used in next patches.
Move rdma_req and cid initialization out of nvme_rdma_req_in

nvme/rdma: Factor our contig request preparation

Move the NVMF configuration to dedicated functions, they
are to be used in next patches.
Move rdma_req and cid initialization out of nvme_rdma_req_init,
that is needed in next patches to support accel sequence

Signed-off-by: Alexey Marchuk <alexeymar@nvidia.com>
Change-Id: I9aca26d96c92d44b1b3f6542c3cf00fe9af9cc4b
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24694
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Community-CI: Mellanox Build Bot
Community-CI: Community CI Samsung <spdk.community.ci.samsung@gmail.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Ben Walker <ben@nvidia.com>

show more ...

lib/rdma_provider: Allow to set data_transfer cb

Extend qpair init attr with data_transfer callback
to be set to the memory domain.
verbs provider doesn't support this functionality
The data_transfe

lib/rdma_provider: Allow to set data_transfer cb

Extend qpair init attr with data_transfer callback
to be set to the memory domain.
verbs provider doesn't support this functionality
The data_transfer callback will be used in next
patches to support accel sequence in nvme_rdma

Signed-off-by: Alexey Marchuk <alexeymar@nvidia.com>
Change-Id: Ibc4aa57057e51ed2e0b687132fdb7a2b4368f5fa
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24693
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Reviewed-by: Ben Walker <ben@nvidia.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Community-CI: Mellanox Build Bot
Community-CI: Community CI Samsung <spdk.community.ci.samsung@gmail.com>

show more ...

nvme/rdma: Allocate memory domain in rdma provider

Next patches add data_transfer function to a memory domain,
for mlx5_dv provider, that means we can't use a memory
domain created via rdma_utils. I

nvme/rdma: Allocate memory domain in rdma provider

Next patches add data_transfer function to a memory domain,
for mlx5_dv provider, that means we can't use a memory
domain created via rdma_utils. In future, memory domain
will hold a qpair pointer, to minize changes we create
a memory domain per qpair in this patch
The verbs provider still uses rdma_utils library.

Signed-off-by: Alexey Marchuk <alexeymar@nvidia.com>
Change-Id: I53c20b70901c1061c8a067c612dc4ce6b9a3999a
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24692
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Ben Walker <ben@nvidia.com>
Community-CI: Community CI Samsung <spdk.community.ci.samsung@gmail.com>

show more ...

nvmf: rename passthrough_nsid -> passthru_nsid

This is the spelling we typically use.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: I40ad23301fd5be6d02b50abb4209ae1c7aeacc96
R

nvmf: rename passthrough_nsid -> passthru_nsid

This is the spelling we typically use.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: I40ad23301fd5be6d02b50abb4209ae1c7aeacc96
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/25396
Community-CI: Mellanox Build Bot
Community-CI: Community CI Samsung <spdk.community.ci.samsung@gmail.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Reviewed-by: Changpeng Liu <changpeliu@tencent.com>
Reviewed-by: GangCao <gang.cao@intel.com>

show more ...

nvmf: use bdev's nsid for admin command passthru

The ID of a namespace exposed by an NVMe-oF subsystem can differ from
the nsid of the underlying namespace that backs a given bdev. For
instance, th

nvmf: use bdev's nsid for admin command passthru

The ID of a namespace exposed by an NVMe-oF subsystem can differ from
the nsid of the underlying namespace that backs a given bdev. For
instance, the following:

$ scripts/rpc.py bdev_nvme_attach_controller -b nvme0 ...
nvme0n1
nvme0n2
$ scripts/rpc.py nvmf_subsystem_add_ns -n 2 nqn nvme0n1
$ scripts/rpc.py nvmf_subsystem_add_ns -n 1 nqn nvme0n2

results in nvme0n1 being exposed with nsid=2, while nvme0n2 with nsid=1.
In this scenario, admin commands targeting a namespace (e.g. identify
namespace) would get sent to the wrong namespace.

Fixes: 05632afd77dd ("nvmf: large IU and atomic write unit reporting")
Reported-by: Maciej Szulik <maciej.szulik@intel.com>
Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: Ib4f7071afb10691c88def880fadc5f4d7e134b07
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/25364
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Maciej Szulik <maciej.szulik@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Reviewed-by: Changpeng Liu <changpeliu@tencent.com>
Community-CI: Community CI Samsung <spdk.community.ci.samsung@gmail.com>
Community-CI: Mellanox Build Bot

show more ...