test/nvme/xnvme: Tidy the test suite

Split common stuff into common.sh which will try to emulate some sort
of a logic for the main tests which should resolve around different
io_mechanisms - the ide

test/nvme/xnvme: Tidy the test suite

Split common stuff into common.sh which will try to emulate some sort
of a logic for the main tests which should resolve around different
io_mechanisms - the idea is to generally remove all the superfluous
checks and have a prep dedicated for each mechanism.

The xnvme_to_malloc_dd_copy test is removed altogether since in
context of xnvme it doesn't add anything sensible to the table -
it's removal won't affect the final code coverage.

Change-Id: If91cc6f2d3f6937fef22c534c57b2972caf26e8b
Signed-off-by: Michal Berger <michal.berger@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/25316
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Community-CI: Community CI Samsung <spdk.community.ci.samsung@gmail.com>
Reviewed-by: Karl Bonde Torp <k.torp@samsung.com>
Reviewed-by: Jim Harris <jim.harris@nvidia.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

test/nvme/xnvme: Add io_uring_cmd

This requires some extra dance since it seems it can work only on top
of generic nvme char devices.

Change-Id: I84a489b64bada9335a30f3db185edba3733b7902
Signed-off

test/nvme/xnvme: Add io_uring_cmd

This requires some extra dance since it seems it can work only on top
of generic nvme char devices.

Change-Id: I84a489b64bada9335a30f3db185edba3733b7902
Signed-off-by: Michal Berger <michal.berger@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/25308
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Community-CI: Community CI Samsung <spdk.community.ci.samsung@gmail.com>
Reviewed-by: Jim Harris <jim.harris@nvidia.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Karl Bonde Torp <k.torp@samsung.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>

show more ...

test/nvme/xnvme: Add different io patterns

Minimal set of what's currently supported depending on the
io_mechanism.

Change-Id: I18c235f6828ee5e7e99174501da8cefe6413539d
Signed-off-by: Michal Berger

test/nvme/xnvme: Add different io patterns

Minimal set of what's currently supported depending on the
io_mechanism.

Change-Id: I18c235f6828ee5e7e99174501da8cefe6413539d
Signed-off-by: Michal Berger <michal.berger@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/25307
Reviewed-by: Karl Bonde Torp <k.torp@samsung.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Reviewed-by: Jim Harris <jim.harris@nvidia.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Community CI Samsung <spdk.community.ci.samsung@gmail.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>

show more ...

test/nvme/xnvme: Add simple RPC validation test

Change-Id: I05a336330480dcce21a488cc7e4583841d5d1536
Signed-off-by: Michal Berger <michal.berger@intel.com>
Reviewed-on: https://review.spdk.io/gerrit

test/nvme/xnvme: Add simple RPC validation test

Change-Id: I05a336330480dcce21a488cc7e4583841d5d1536
Signed-off-by: Michal Berger <michal.berger@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/25306
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Reviewed-by: Jim Harris <jim.harris@nvidia.com>
Reviewed-by: Karl Bonde Torp <k.torp@samsung.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Community CI Samsung <spdk.community.ci.samsung@gmail.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>

show more ...

test/nvme/xnvme: Add simple test with SPDK's fio plugin

It mirrors bdevperf setup to some extent, with extra numjobs +
conserve_cpu enabled on top. This is mainly to see if slapping
that extra arg d

test/nvme/xnvme: Add simple test with SPDK's fio plugin

It mirrors bdevperf setup to some extent, with extra numjobs +
conserve_cpu enabled on top. This is mainly to see if slapping
that extra arg doesn't break anything.

Change-Id: I60445af635641c41fc779e5c2ce18a00e0130b60
Signed-off-by: Michal Berger <michal.berger@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/25305
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Community-CI: Community CI Samsung <spdk.community.ci.samsung@gmail.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Reviewed-by: Karl Bonde Torp <k.torp@samsung.com>
Reviewed-by: Jim Harris <jim.harris@nvidia.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

scripts/rpc: Fix conserve_cpu arg in bdev_xnvme_create()

Currently, there's no way to actually change this arg while calling
this particular rpc. So make sure it's possible, and keep it as an
option

scripts/rpc: Fix conserve_cpu arg in bdev_xnvme_create()

Currently, there's no way to actually change this arg while calling
this particular rpc. So make sure it's possible, and keep it as an
optional arg with default still set to False (as per b99b00e595).

Change-Id: I889179bfa46a6261d2e30eeba4a5a14395e756a5
Signed-off-by: Michal Berger <michal.berger@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/25287
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Reviewed-by: Pawel Piatek <pawelx.piatek@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Jim Harris <jim.harris@nvidia.com>
Community-CI: Community CI Samsung <spdk.community.ci.samsung@gmail.com>
Reviewed-by: Karl Bonde Torp <k.torp@samsung.com>

show more ...

bdev/xnvme: Make sure conserve_cpu opt is preserved in the struct

Change-Id: I253ecbdea35a44ef546785770a09f44be7ffbaaf
Signed-off-by: Michal Berger <michal.berger@intel.com>
Reviewed-on: https://rev

bdev/xnvme: Make sure conserve_cpu opt is preserved in the struct

Change-Id: I253ecbdea35a44ef546785770a09f44be7ffbaaf
Signed-off-by: Michal Berger <michal.berger@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/25303
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Reviewed-by: Karl Bonde Torp <k.torp@samsung.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Reviewed-by: Jim Harris <jim.harris@nvidia.com>
Community-CI: Mellanox Build Bot
Community-CI: Community CI Samsung <spdk.community.ci.samsung@gmail.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

vhost_blk: return VIRTIO_BLK_S_UNSUPP for flush command

SPDK vhost-blk doesn't negociate `VIRTIO_BLK_F_FLUSH` nor
`VIRTIO_BLK_F_CONFIG_WCE` feature bits, but we can still
receive FLUSH commands from

vhost_blk: return VIRTIO_BLK_S_UNSUPP for flush command

SPDK vhost-blk doesn't negociate `VIRTIO_BLK_F_FLUSH` nor
`VIRTIO_BLK_F_CONFIG_WCE` feature bits, but we can still
receive FLUSH commands from VM, here we return correct
errno for these commands in case the backend block device
doesn't support it.

Partly fix issue #3572.

Change-Id: Ib6269818ae94b38bebed3603fa8b87e97d7e7ab1
Signed-off-by: Changpeng Liu <changpeliu@tencent.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/25435
Community-CI: Community CI Samsung <spdk.community.ci.samsung@gmail.com>
Reviewed-by: Jim Harris <jim.harris@nvidia.com>
Community-CI: Mellanox Build Bot
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Reviewed-by: GangCao <gang.cao@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

scripts/bash-completion: Speed up rpc lookup

Do this by caching completions to avoid costly run through the help
parser. We cache each completion since it's very unlikely that help
for given RPC met

scripts/bash-completion: Speed up rpc lookup

Do this by caching completions to avoid costly run through the help
parser. We cache each completion since it's very unlikely that help
for given RPC method may suddenly change.

One exception here is a list of available RPCs methods which may
change depending on if rpc.py "get"s it while connecting through
an actual app socket. Here, we need to reset the cached list whenever
sock changes or when actual list gets cleaned up.

The overall result should be better user experience with faster
responsiveness while tab'ing through the available opts.

Change-Id: Ia2e10957558095e22adc57aaed300e121c682d40
Signed-off-by: Michal Berger <michal.berger@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/25362
Community-CI: Community CI Samsung <spdk.community.ci.samsung@gmail.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Reviewed-by: Jim Harris <jim.harris@nvidia.com>

show more ...

test/autobuild: bump minimum version of intel-ipsec-mb

Starting from DPDK 24.11.0, the minimum required version of
intel-ipsec-mb is 1.5.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Ch

test/autobuild: bump minimum version of intel-ipsec-mb

Starting from DPDK 24.11.0, the minimum required version of
intel-ipsec-mb is 1.5.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: Ib6547841b317587f27698bd5b96aa2a8702ce5ae
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/25428
Reviewed-by: Michal Berger <michal.berger@intel.com>
Reviewed-by: Jim Harris <jim.harris@nvidia.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Community-CI: Community CI Samsung <spdk.community.ci.samsung@gmail.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

dpdk: add adjustments for recent rte_power changes

There were a couple of changes to the rte_power library:
1) Hardware-specific code was moved out of rte_ower into individual
drivers under the

dpdk: add adjustments for recent rte_power changes

There were a couple of changes to the rte_power library:
1) Hardware-specific code was moved out of rte_ower into individual
drivers under the drivers/power directory.
2) The header file was renamed rte_power.h -> rte_power_cpufreq.h.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: Iac8aeb99423a21905a8bea744ccf662539b26da0
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/25424
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Michal Berger <michal.berger@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <jim.harris@nvidia.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Community-CI: Community CI Samsung <spdk.community.ci.samsung@gmail.com>

show more ...

bdev: fix per_channel data null when bdev_get_iostat with reset option

When bdev_get_iostat comes with the reset option, we should reset the
channel or bdev's stat memory area, not that stat memory

bdev: fix per_channel data null when bdev_get_iostat with reset option

When bdev_get_iostat comes with the reset option, we should reset the
channel or bdev's stat memory area, not that stat memory area
temporarily allocated for rpc output.

Fixes: 63e0c25d ("bdev: add reset_mode to bdev_get_iostat")
Change-Id: I32caaca48c84600b6c3c403ae647d6d3ce6cd5ae
Signed-off-by: Yao Liu <liuy35@chinatelecom.cn>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/25441
Community-CI: Mellanox Build Bot
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Reviewed-by: GangCao <gang.cao@intel.com>
Community-CI: Community CI Samsung <spdk.community.ci.samsung@gmail.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Changpeng Liu <changpeliu@tencent.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>

show more ...

lib/reduce: fix the magic number of empty mapping detection.

In debug mode, when the backing dev capacity is greater than 16TB, the value of io_unit_index is likely to be UINT32_MAX. Similarly, when

lib/reduce: fix the magic number of empty mapping detection.

In debug mode, when the backing dev capacity is greater than 16TB, the value of io_unit_index is likely to be UINT32_MAX. Similarly, when the capacity is greater than 64TB, the value of chunk_map_index may be UINT32_MAX.
These above situations may cause coredump to be triggered incorrectly.

Change-Id: I9d89102531daebd779b3f0eb6386f478bfcaa80b
Signed-off-by: Yalong Wang <yalong9@staff.sina.com.cn>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/25427
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Reviewed-by: GangCao <gang.cao@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Changpeng Liu <changpeliu@tencent.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Community CI Samsung <spdk.community.ci.samsung@gmail.com>
Reviewed-by: Jim Harris <jim.harris@nvidia.com>

show more ...

bdev_ut: add manual examine bdev unit test case

This commit adds a unit test case for the manual Bdev examination
workflow and validates that a Bdev can be re-registered under the
same name when the

bdev_ut: add manual examine bdev unit test case

This commit adds a unit test case for the manual Bdev examination
workflow and validates that a Bdev can be re-registered under the
same name when the autoexamine Bdev option is disabled.

Change-Id: Ideefe1c60fe7efb4191caca88c3551674781f987
Signed-off-by: Ed Reed <edreed@microsoft.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/25425
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Jim Harris <jim.harris@nvidia.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Community CI Samsung <spdk.community.ci.samsung@gmail.com>
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>

show more ...

bdev: remove bdev from examine allow list on unregister

Removes the Bdev from the examine allow list on unregister to enable
re-registration of a Bdev with the same name.

Change-Id: Iefcb5ff8addd78

bdev: remove bdev from examine allow list on unregister

Removes the Bdev from the examine allow list on unregister to enable
re-registration of a Bdev with the same name.

Change-Id: Iefcb5ff8addd7859df56f1f2a3ce3cc309fde528
Signed-off-by: Ed Reed <edreed@microsoft.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/25426
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Community-CI: Community CI Samsung <spdk.community.ci.samsung@gmail.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Reviewed-by: Jim Harris <jim.harris@nvidia.com>

show more ...

bdev/nvme: Make bdev nvme get and set opts APIs public

This patch exposes bdev_nvme_get_opts and bdev_nvme_set_opts APIs.
No changes have been done to the implementation of these functions.

Change-

bdev/nvme: Make bdev nvme get and set opts APIs public

This patch exposes bdev_nvme_get_opts and bdev_nvme_set_opts APIs.
No changes have been done to the implementation of these functions.

Change-Id: I8498ed81e14abb66283a1608f17bb6bba8e38975
Signed-off-by: Yash Raj Singh <yash.rajsingh@nutanix.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/25406
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Community-CI: Community CI Samsung <spdk.community.ci.samsung@gmail.com>
Reviewed-by: Jim Harris <jim.harris@nvidia.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Ankit Kumar <ankit.kumar@samsung.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

bdev/nvme: Rearrange fields in spdk_bdev_nvme_opts to reduce holes.

This patch rearranges the fields in spdk_bdev_nvme_opts to reduce the
number of holes in the structure which reduces the size of t

bdev/nvme: Rearrange fields in spdk_bdev_nvme_opts to reduce holes.

This patch rearranges the fields in spdk_bdev_nvme_opts to reduce the
number of holes in the structure which reduces the size of the overall
structure. This is required as a preliminary step to expose the
bdev_nvme_get_opts and bdev_nvme_set_opts functions to the public API.
Later patches will add these functions to the public API.

Change-Id: I6402afecd582297b3ead98383016e6c8dfd385ba
Signed-off-by: Yash Raj Singh <yash.rajsingh@nutanix.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/25299
Reviewed-by: Ankit Kumar <ankit.kumar@samsung.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <jim.harris@nvidia.com>
Community-CI: Community CI Samsung <spdk.community.ci.samsung@gmail.com>
Community-CI: Mellanox Build Bot

show more ...

bdev/nvme: Move the spdk_bdev_nvme_opts and spdk_bdev_timeout_action struct to the public header.

This patch moves the spdk_bdev_nvme_opts and spdk_bdev_timeout_action
structs to the public header f

bdev/nvme: Move the spdk_bdev_nvme_opts and spdk_bdev_timeout_action struct to the public header.

This patch moves the spdk_bdev_nvme_opts and spdk_bdev_timeout_action
structs to the public header file include/spdk/module/bdev/nvme.h This
is required as a preliuminary step to expose the bdev_nvme_get_opts and
bdev_nvme_set_opts functions to the public API. Later patches will add
these functions to the public API.

Change-Id: Ib6bd16fa085a60f29dd920b4f9c350fa4ffb4c76
Signed-off-by: Yash Raj Singh <yash.rajsingh@nutanix.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/25172
Reviewed-by: Jim Harris <jim.harris@nvidia.com>
Community-CI: Community CI Samsung <spdk.community.ci.samsung@gmail.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Ankit Kumar <ankit.kumar@samsung.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>

show more ...

bdev: fix a race between reset start and complete

There is a race between reset start and complete:

1. reset_1 is completing. It clears bdev->internal.reset_in_progress and
sends unfreeze_channe

bdev: fix a race between reset start and complete

There is a race between reset start and complete:

1. reset_1 is completing. It clears bdev->internal.reset_in_progress and
sends unfreeze_channel messages to remove queued resets of all
channels.
2. reset_2 is starting. As bdev->internal.reset_in_progress has been
cleared, it is inserted to queued_resets list and starts to freeze
channels.
3. reset_1's unfreeze_channel message removes reset_2 from queued_resets
list.
4. reset_2 finishes freezing channels, but the corresponding bdev_io has
gone, hence resulting in segmentation fault.

To fix this, we use per-bdev queued_resets list instead of per-channel
ones, and nullify bdev->internal.reset_in_progress after unfreezing bdev
channels. In this way, we can assure that all resets submitted during an
in-progress reset can be queued and completed correctly.

Besides, we do not insert the reset that is submitted to the underlying
device into the queued_resets list, so that the list can be processsed
cleanly.

Change-Id: I7cb14d790c1e20cea86e4829555d04acc408ee28
Signed-off-by: Jinlong Chen <chenjinlong.cjl@alibaba-inc.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/25371
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Community-CI: Community CI Samsung <spdk.community.ci.samsung@gmail.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Reviewed-by: GangCao <gang.cao@intel.com>

show more ...

nvmf/fc: Qpair disconnect callback: Serialize FC delete connection & close qpair process

An invalid pointer access can happen with KATO and FC delete
connection running parallelly. This is a

nvmf/fc: Qpair disconnect callback: Serialize FC delete connection & close qpair process

An invalid pointer access can happen with KATO and FC delete
connection running parallelly. This is a regression that got
introduced when the qpair disconnect callback was removed.

Change-Id: I8cf4ca3c3d91797e44c501e09222f503e00db4be
Signed-off-by: Kalyan Kadiyala <kalyan.kadiyala@broadcom.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/25421
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Community-CI: Community CI Samsung <spdk.community.ci.samsung@gmail.com>

show more ...

nvmf/fc: Validate the ctrlr pointer inside nvmf_fc_req_bdev_abort()

An abort request can come in for a fabric connect command before
the ctrlr is initialized. In such a case, accessing the c

nvmf/fc: Validate the ctrlr pointer inside nvmf_fc_req_bdev_abort()

An abort request can come in for a fabric connect command before
the ctrlr is initialized. In such a case, accessing the ctrlr
pointer without validating it can lead to app crash.

Change-Id: I61b79147330e566d4393a72c6a07d0dd6e032e80
Signed-off-by: Kalyan Kadiyala <kalyan.kadiyala@broadcom.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/25420
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Community-CI: Mellanox Build Bot
Community-CI: Community CI Samsung <spdk.community.ci.samsung@gmail.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

correct kick for CQ full case

We implement basic flow control by not processing any submissions while
the CQ is full. However, in interrupt mode, the code was mistakenly
attempting to kick ctrlr->in

correct kick for CQ full case

We implement basic flow control by not processing any submissions while
the CQ is full. However, in interrupt mode, the code was mistakenly
attempting to kick ctrlr->intr_fd - this will not go well, as this is
the vfio-user socket fd, not an eventfd. It should be kicking the SQ
group's eventfd.

Fixes: 23b518a0 ("nvmf/vfio_user: mitigate cq full race")
Signed-off-by: John Levon <john.levon@nutanix.com>
Change-Id: Ia3b5ad8ffe4118a620fc3894e40fc95c251cd009
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/25401
Reviewed-by: Changpeng Liu <changpeliu@tencent.com>
Community-CI: Mellanox Build Bot
Community-CI: Community CI Samsung <spdk.community.ci.samsung@gmail.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>

show more ...

test/nvmf: Interrupt test for local pcie nvme device

Change-Id: I62196ca5b84a622c60cbea465fb3cb5c7ef680dc
Signed-off-by: Ankit Kumar <ankit.kumar@samsung.com>
Reviewed-on: https://review.spdk.io/ger

test/nvmf: Interrupt test for local pcie nvme device

Change-Id: I62196ca5b84a622c60cbea465fb3cb5c7ef680dc
Signed-off-by: Ankit Kumar <ankit.kumar@samsung.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/25378
Reviewed-by: Michal Berger <michal.berger@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Community-CI: Community CI Samsung <spdk.community.ci.samsung@gmail.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>

show more ...

nvme/perf: interrupt mode support for pcie controller

Added interrupt mode tests, which can be enabled for pcie nvme devices
by passing '-E'

Example:
./build/bin/spdk_nvme_perf -q 1 -o 4096 -w read

nvme/perf: interrupt mode support for pcie controller

Added interrupt mode tests, which can be enabled for pcie nvme devices
by passing '-E'

Example:
./build/bin/spdk_nvme_perf -q 1 -o 4096 -w read -t 30 -P 1 -E

Events are registered for the fds of all the I/O qpairs during its
creation. During nvme_check_io() spdk_nvme_poll_group_wait() is called,
which processes any queue pair with interrupt events.

Change-Id: I5cb4e551a14062fe0203f165f28e4e97a3634108
Signed-off-by: Ankit Kumar <ankit.kumar@samsung.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24908
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Community-CI: Community CI Samsung <spdk.community.ci.samsung@gmail.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot

show more ...

test/scheduler: Read PID's status file only once

There's some peculiar issue where reading this file line by line can
be tainted by sudden updates to the file resulting in given fields
being unrecog

test/scheduler: Read PID's status file only once

There's some peculiar issue where reading this file line by line can
be tainted by sudden updates to the file resulting in given fields
being unrecognized by the get_proc_cpu_affinity(). To avoid that,
make sure this file is read once in full before parsing.

Change-Id: Ied4f03ada3b354b666df71f4d5f5d2467a874d98
Signed-off-by: Michal Berger <michal.berger@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/25407
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Community-CI: Community CI Samsung <spdk.community.ci.samsung@gmail.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>

show more ...