In hibernate_write_chunks(), keep track of relative block numbers instead
of absolute, so that we can add range checking.
ok mlarkin

spacing

return the known error, instead of EIO

shorten dev_t in hib_info

shorten variable name for the hibernate info struct, throughout. Much
easier to read now.
ok mlarkin

use DEV_BSIZE instead of "secsize"
ok mlarkin

teach the side-effect free drivers about the partition they are dealing
by passing a start/length in the HIB_INIT op. Then rebase all
hibernate-time block offsets to be relative to the start of that

teach the side-effect free drivers about the partition they are dealing
by passing a start/length in the HIB_INIT op. Then rebase all
hibernate-time block offsets to be relative to the start of that partition.
This simplifies things a lot.
ok mlarkin

show more ...

Errant assignment that snuck in long ago. Pointed out by deraadt@

Change an #if 0 surrounding a debug printf into a DPRINTF instead.

new function uvm_hibswap() finds a the largest free zone in swap, which
hibernate can use place the data.
ok mlarkin

Replace direct references to p_size, p_offset and d_secperunit with
DL_[GET|SET]PSIZE(), DL_[GET|SET]POFFSET(), DL_[GET|SET]DSIZE() in
order to get|set correct value that includes the high bits of th

Replace direct references to p_size, p_offset and d_secperunit with
DL_[GET|SET]PSIZE(), DL_[GET|SET]POFFSET(), DL_[GET|SET]DSIZE() in
order to get|set correct value that includes the high bits of the
value.

show more ...

Informational message on unpack start

Provide more debugging aids when failing to read the packed image from disk
during hibernate resume.

requested by deraadt

DPRINTFs for various failure cases, disabled by default (uncomment
HIB_DEBUG to see these)

Flush the cache after bouncing the inflate page to the piglet.

Fixes resume time stream corruption seen on x230 with large (16GB)
unhibernation

Use a second inflate page for stream finalize, since it is possible
(though unlikely) for the end of stream marker to overflow from one page.
This should fix a few (but not all) spurious failure-to-h

Use a second inflate page for stream finalize, since it is possible
(though unlikely) for the end of stream marker to overflow from one page.
This should fix a few (but not all) spurious failure-to-hibernate errors.

Also remove an unnecessary cache flush during deflate.

ok deraadt

show more ...

Adds DPRINTF/DNPRINTF macros to hibernate, and adds invocation of said
macros in various places to assist in debugging "failure to hibernate"
errors.

Macros are disabled by default - Uncomment #defi

Adds DPRINTF/DNPRINTF macros to hibernate, and adds invocation of said
macros in various places to assist in debugging "failure to hibernate"
errors.

Macros are disabled by default - Uncomment #define HIB_DEBUG if you want
more verbose messages during hibernate.

show more ...

Print out the compressed image size during unhibernate, for diagnostic
purposes and to give the user an idea as to how much is going to be read
in.

Work around stack smash protector getting confused because we switched
stacks by not returning (ever) from hibernate_unpack_image.

Change return codes in various hibernate functions to be able to later
distinguish one failure path from another. Comment the same.

Also removed some extraneous comments regarding pmap_activate.

We need to halt the APs on MP hibernate resume or else they will be
executing code possibly causing side effects during the image unpack
operation. But before we can halt the APs, we need to complete

We need to halt the APs on MP hibernate resume or else they will be
executing code possibly causing side effects during the image unpack
operation. But before we can halt the APs, we need to complete their init
(as they will be hatched but idling, possibly with interrupts off).

Introduces MD function hibernate_quiesce_cpus to do this, called from the
MI hibernate resume code.

ok deraadt

show more ...

Make interrupt handling in hibernate resume MI by providing MD-specific
functions to enable and disable interrupts, if needed. If a platform doesnt
need interrupt handling in this way, the MD functio

Make interrupt handling in hibernate resume MI by providing MD-specific
functions to enable and disable interrupts, if needed. If a platform doesnt
need interrupt handling in this way, the MD function can be a no-op.

discussed with pirofti and deraadt

show more ...

Comment a KASSERT whose purpose wasn't immediately apparent

Add a magic number to the head of the signature block. Check for magic
number match during signature block read during speculative unhibernate on
boot. If the magic number matches but we have otherwi

Add a magic number to the head of the signature block. Check for magic
number match during signature block read during speculative unhibernate on
boot. If the magic number matches but we have otherwise chosen to not
unhibernate (due to kernel/memory mismatch), clear the signature block
early to avoid accidentally trying to unhibernate on subsequent boots. This
prevents accidental unhibernates and endless unhibernate/reboot cycles.

Add a define for HIBERNATE_DEBUG for various debugging printfs (disabled by
default).

Finally, change some KASSERTs to warning printfs (they probably shouldn't
have been KASSERTs in the first place).

"looks good" deraadt@

show more ...

sys/param.h gets you sys/types.h automatically