Make _kernel_lock_held() always succeed after panic(9).

ok visa@

Drop unnecessary headers. This fixes kernel build on platforms
without <machine/mplock.h>.

Hook up mplock to witness(4) on amd64 and i386.

Remove the lockmgr() API. It is only used by filesystems, where it is a
trivial change to use rrw locks instead. All it needs is LK_* defines
for the RW_* flags.

tested by naddy and sthen on package

Remove the lockmgr() API. It is only used by filesystems, where it is a
trivial change to use rrw locks instead. All it needs is LK_* defines
for the RW_* flags.

tested by naddy and sthen on package building infrastructure
input and ok jmc mpi tedu

show more ...

remove uneeded proc.h includes
ok mpi@ kspillner@

KERNEL_ASSERT_LOCKED(9): Assertion for kernel lock (Rev. 3)

This adds a new assertion macro, KERNEL_ASSERT_LOCKED(), to assert that
kernel_lock is held. In the long process of removing kernel_lock,

KERNEL_ASSERT_LOCKED(9): Assertion for kernel lock (Rev. 3)

This adds a new assertion macro, KERNEL_ASSERT_LOCKED(), to assert that
kernel_lock is held. In the long process of removing kernel_lock, there will
be a lot (hundreds or thousands) of use of this; virtually almost all functions
in !MP-safe subsystems should have this assertion. Thus this assertion should
have a short, good name.

Not only that "KERNEL_ASSERT_LOCKED" is consistent with other KERNEL_* and
SCHED_ASSERT_LOCKED() macros.

Input from dlg@ guenther@ kettenis@.

OK dlg@ guenther@

show more ...

Teach rw_status() and rrw_status() to return LK_EXCLOTHER if it's write
locked by a different thread. Teach lockstatus() to return LK_EXCLUSIVE
if an exclusive lock is held by some other thread.

ok

Teach rw_status() and rrw_status() to return LK_EXCLOTHER if it's write
locked by a different thread. Teach lockstatus() to return LK_EXCLUSIVE
if an exclusive lock is held by some other thread.

ok beck@ tedu@

show more ...

bzero -> memset

restore original gangster lockstatus return values for compat

a few tweaks noticed by jsing

exorcise lockmgr. the api remains, but is now backed by recursive rwlocks.
originally by thib.
ok deraadt jsing and anyone who tested

do not include machine/cpu.h from a .c file; it is the responsibility of
.h files to pull it in, if needed
ok tedu

lockmgr() wants to use a different address for the wchan when draining
the lock, but a change in member ordering meant it was using the same
address. Explicitly use different members instead of mixi

lockmgr() wants to use a different address for the wchan when draining
the lock, but a change in member ordering meant it was using the same
address. Explicitly use different members instead of mixing address
of member and address of the lock itself.

ok miod@

show more ...

Clean up after P_BIGLOCK removal.
KERNEL_PROC_LOCK -> KERNEL_LOCK
KERNEL_PROC_UNLOCK -> KERNEL_UNLOCK

oga@ ok

Stop using the P_BIGLOCK flag to figure out when we should release the
biglock in mi_switch and just check if we're holding the biglock.

The idea is that the first entry point into the kernel uses K

Stop using the P_BIGLOCK flag to figure out when we should release the
biglock in mi_switch and just check if we're holding the biglock.

The idea is that the first entry point into the kernel uses KERNEL_PROC_LOCK
and recursive calls use KERNEL_LOCK. This assumption is violated in at
least one place and has been causing confusion for lots of people.

Initial bug report and analysis from Pedro.

kettenis@ beck@ oga@ thib@ dlg@ ok

show more ...

cut down simple locks (so simple that they don't even lock) to the point
where there is almost nothing left to them, so that we can continue getting
rid of them
ok oga

fix typos in comments, no code changes;
from Brad Tilley <brad at 16systems dot com>;
ok oga@

ntfs was the last user, LK_SLEEFAIL can die now.

ok blambert@

Surround WEHOLDIT() macro with braces to make it more safe.
No binary change.

ok otto@

Remove some dead code that is confusing my greps.

remove p_lock from struct proc; unused debug goo for lockmgr,
wich gets set and never checked etc...

ok art@,tedu@

Don't use LK_CANRECURSE for the kernel lock, okay miod@ art@

lockmgr_printinfo() is only called from #ifdef DIAGNOSTIC positions, so #ifdef DIAGNOSTIC it too

Remove the lk_interlock from struct lock; Also remove the LK_INTERLOCK
flag. This effectively makes the simplelock argument to lockmgr() fluff.

ok miod@

lockmgr keeps losing code, call 911!

ok pedro@ art@