Tweak warning text for nil value in ObjC container warning.

llvm-svn: 179034

[analyzer] Reword error messages for nil keys and values of NSMutableDictionary.

llvm-svn: 178935

[analyzer] Make sure IDC works for ‘NSContainer value/key is nil’ checks.

Register the nil tracking visitors with the region and refactor trackNullOrUndefValue a bit.

Also adds the cast and paren s

[analyzer] Make sure IDC works for ‘NSContainer value/key is nil’ checks.

Register the nil tracking visitors with the region and refactor trackNullOrUndefValue a bit.

Also adds the cast and paren stripping before checking if the value is an OpaqueValueExpr
or ExprWithCleanups.

llvm-svn: 178093

show more ...

[analyzer] Warn when a nil key or value are passed to NSMutableDictionary and ensure it works with subscripting.

llvm-svn: 177789

[analyzer] Warn when a ‘nil’ object is added to NSArray or NSMutableArray.

llvm-svn: 177318

[analyzer] Rename AttrNonNullChecker -> NonNullParamChecker

llvm-svn: 176755

Avoid implicit conversions of Optional<T> to bool.

This is a precursor to making Optional<T>'s operator bool 'explicit' when
building Clang & LLVM as C++11.

llvm-svn: 175722

Use None rather than Optional<T>() where possible.

llvm-svn: 175705

Include llvm::Optional in clang/Basic/LLVM.h

Post-commit CR feedback from Jordan Rose regarding r175594.

llvm-svn: 175679

Remove redundant Optional type in favor of llvm::Optional

llvm-svn: 175678

Replace SVal llvm::cast support to be well-defined.

See r175462 for another example/more details.

llvm-svn: 175594

Sort all of Clang's files under 'lib', and fix up the broken headers
uncovered.

This required manually correcting all of the incorrect main-module
headers I could find, and running the new llvm/util

Sort all of Clang's files under 'lib', and fix up the broken headers
uncovered.

This required manually correcting all of the incorrect main-module
headers I could find, and running the new llvm/utils/sort_includes.py
script over the files.

I also manually added quite a few missing headers that were uncovered by
shuffling the order or moving headers up to be main-module-headers.

llvm-svn: 169237

show more ...

Include pruning and general cleanup.

llvm-svn: 169095

[analyzer] Check that the argument to CFMakeCollectable is non-NULL.

Patch by Sean McBride!

llvm-svn: 167537

[analyzer] Remove isWithinInlined. It's been replaced with inTopFrame().

Thanks Jordan.

llvm-svn: 167438

[analyzer] Rename 'EmitReport' to 'emitReport'.

No functionality change.

llvm-svn: 167275

[analyzer] Fix a buildbot crash triggered by turning on dynamic
dispatch.

llvm-svn: 164579

Make helper functions static.

llvm-svn: 163505

[analyzer] Remove cast inside dyn_cast.

llvm-svn: 162951

[analyzer] Fixup for r162935 as per Jordan's review.

Thanks for catching this!

llvm-svn: 162949

[analyzer] Do not propagate the [super init] could be nil assumption
from callee to caller.

radar://12109638

llvm-svn: 162935

[analyzer] Rename addTrackNullOrUndefValueVisitor to trackNullOrUndefValue.

This helper function (in the clang::ento::bugreporter namespace) may add more
than one visitor, but conceptually it's trac

[analyzer] Rename addTrackNullOrUndefValueVisitor to trackNullOrUndefValue.

This helper function (in the clang::ento::bugreporter namespace) may add more
than one visitor, but conceptually it's tracking a single use of a null or
undefined value and should do so as best it can.

Also, the BugReport parameter has been made a reference to underscore that
it is non-optional.

llvm-svn: 162720

show more ...

[analyzer] Fixup to r162399. Initialize the member variable.

llvm-svn: 162405

[analyzer] Add osx.cocoa.NonNilReturnValue checker.

The checker adds assumptions that the return values from the known APIs
are non-nil. Teach the checker about NSArray/NSMutableArray/NSOrderedSet
o

[analyzer] Add osx.cocoa.NonNilReturnValue checker.

The checker adds assumptions that the return values from the known APIs
are non-nil. Teach the checker about NSArray/NSMutableArray/NSOrderedSet
objectAtIndex, objectAtIndexedSubscript.

llvm-svn: 162398

show more ...

[analyzer] When a symbol is null, we should track its constraints.

Because of this, we would previously emit NO path notes when a parameter
is constrained to null (because there are no stores). Now

[analyzer] When a symbol is null, we should track its constraints.

Because of this, we would previously emit NO path notes when a parameter
is constrained to null (because there are no stores). Now we show where we
made the assumption, which is much more useful.

llvm-svn: 161280

show more ...