#
ce5c57ac |
| 16-Jun-2021 |
Lance Richardson <lance.richardson@broadcom.com> |
net/bnxt: fix Tx descriptor status implementation
With Tx completion batching, a single transmit completion can correspond to one or more transmit descriptors, adjust implementation to account for t
net/bnxt: fix Tx descriptor status implementation
With Tx completion batching, a single transmit completion can correspond to one or more transmit descriptors, adjust implementation to account for this.
RTE_ETH_TX_DESC_DONE should be returned for descriptors that are available for use instead of RTE_ETH_TX_DESC_UNAVAIL.
Fixes: 5735eb241947 ("net/bnxt: support Tx batching") Fixes: 478ed3bb7b9d ("net/bnxt: support Tx descriptor status") Cc: stable@dpdk.org
Signed-off-by: Lance Richardson <lance.richardson@broadcom.com> Reviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
show more ...
|
#
c6c90a33 |
| 16-Jun-2021 |
Lance Richardson <lance.richardson@broadcom.com> |
net/bnxt: fix ring and context memory allocation
Use requested socket ID when allocating memory for transmit rings, receive rings, and completion queues. Use device NUMA ID when allocating context m
net/bnxt: fix ring and context memory allocation
Use requested socket ID when allocating memory for transmit rings, receive rings, and completion queues. Use device NUMA ID when allocating context memory, notification queue rings, async completion queue rings, and VNIC attributes.
Fixes: 6eb3cc2294fd ("net/bnxt: add initial Tx code") Fixes: 9738793f28ec ("net/bnxt: add VNIC functions and structs") Fixes: f8168ca0e690 ("net/bnxt: support thor controller") Fixes: bd0a14c99f65 ("net/bnxt: use dedicated CPR for async events") Fixes: 683e5cf79249 ("net/bnxt: use common NQ ring") Cc: stable@dpdk.org
Signed-off-by: Lance Richardson <lance.richardson@broadcom.com> Reviewed-by: Somnath Kotur <somnath.kotur@broadcom.com> Reviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
show more ...
|
#
8ac3cbba |
| 09-Jun-2021 |
Kalesh AP <kalesh-anakkur.purayil@broadcom.com> |
net/bnxt: invoke device removal event on recovery failure
When the driver receives RESET_NOTIFY async event from FW or detects a FW fatal error condition, it tries to recover from the error. When th
net/bnxt: invoke device removal event on recovery failure
When the driver receives RESET_NOTIFY async event from FW or detects a FW fatal error condition, it tries to recover from the error. When the driver fails to recover from the error condition, fixed to send device removal event to the application.
Fixes: df6cd7c1f73a ("net/bnxt: handle reset notify async event from FW") Cc: stable@dpdk.org
Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com> Reviewed-by: Somnath Kotur <somnath.kotur@broadcom.com> Reviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
show more ...
|
#
a3a1db0a |
| 09-Jun-2021 |
Kalesh AP <kalesh-anakkur.purayil@broadcom.com> |
net/bnxt: fix typo in log message
In bnxt_rss_hash_update_op, check for valid RSS hashkey length is made against size HW_HASH_KEY_SIZE(40). But the failure log says "Invalid hashkey length, should b
net/bnxt: fix typo in log message
In bnxt_rss_hash_update_op, check for valid RSS hashkey length is made against size HW_HASH_KEY_SIZE(40). But the failure log says "Invalid hashkey length, should be 16 bytes".
Fixes: 91aee9711ee3 ("net/bnxt: validate RSS hash key length") Cc: stable@dpdk.org
Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com> Reviewed-by: Somnath Kotur <somnath.kotur@broadcom.com> Reviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com> Reviewed-by: Venkat Duvvuru <venkatkumar.duvvuru@broadcom.com>
show more ...
|
#
8879ece5 |
| 09-Jun-2021 |
Kalesh AP <kalesh-anakkur.purayil@broadcom.com> |
net/bnxt: cleanup code
This is a cleanup commit and no functional change.
1. use macros instead of hard coded values 2. remove unnecessary comments
Fixes: 5cd0e2889c43 ("net/bnxt: support NIC Part
net/bnxt: cleanup code
This is a cleanup commit and no functional change.
1. use macros instead of hard coded values 2. remove unnecessary comments
Fixes: 5cd0e2889c43 ("net/bnxt: support NIC Partitioning") Fixes: 2ba07b7dbd9d ("net/bnxt: set the hash key size") Cc: stable@dpdk.org
Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com> Reviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
show more ...
|
#
6253a234 |
| 09-Jun-2021 |
Kalesh AP <kalesh-anakkur.purayil@broadcom.com> |
net/bnxt: dump SFP module info
Add support to fetch the SFP EEPROM settings from the firmware. For SFP+ modules we will display 0xA0 page for status and 0xA2 page for other information. For QSFP mod
net/bnxt: dump SFP module info
Add support to fetch the SFP EEPROM settings from the firmware. For SFP+ modules we will display 0xA0 page for status and 0xA2 page for other information. For QSFP modules we will show the 0xA0 page.
Also identify the module types for QSFP28, QSFP, QSFP+ apart from the SFP modules and return an error for 10GBase-T PHY.
Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com> Reviewed-by: Somnath Kotur <somnath.kotur@broadcom.com> Reviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com> Reviewed-by: Venkat Duvvuru <venkatkumar.duvvuru@broadcom.com>
show more ...
|
#
c6062ec0 |
| 30-May-2021 |
Mike Baucom <michael.baucom@broadcom.com> |
net/bnxt: add shared session support to ULP
Shared session permits cooperative sharing of prescribed resources between applications.
- devargs added for app-id in order to enable sharing session
net/bnxt: add shared session support to ULP
Shared session permits cooperative sharing of prescribed resources between applications.
- devargs added for app-id in order to enable sharing session resources across applications - shared session management added - TRUFLOW resource reservations are now app ID and device dependent
Signed-off-by: Mike Baucom <michael.baucom@broadcom.com> Signed-off-by: Venkat Duvvuru <venkatkumar.duvvuru@broadcom.com> Reviewed-by: Kishore Padmanabha <kishore.padmanabha@broadcom.com> Reviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
show more ...
|
#
ddaf0afa |
| 30-May-2021 |
Kishore Padmanabha <kishore.padmanabha@broadcom.com> |
net/bnxt: refactor ULP mapper
1. The internal and external exact match table resource types is combined since the resource handle contains the encoded type whether it is internal or external exact m
net/bnxt: refactor ULP mapper
1. The internal and external exact match table resource types is combined since the resource handle contains the encoded type whether it is internal or external exact match entry.
2. When a flow doesn't hit the offloaded rules, the default action is to send it to the kernel (L2 driver interface). In order to do that, TRUFLOW must know the kernel interface's (PF's) default vnic id. This patch fetches the PF's default vnic id from the dpdk core and stores it in port database. It also stores the mac addr for the future usage. Renamed compute field for layer 4 port enums. Added support for port database opcode that can get port details like mac address which can then be populated in the l2 context entry.
3. Both active and default bit set need to considered to check if a specific flow type is enabled or not.
4. ulp mapper fetches the dpdk port id from the compute field index BNXT_ULP_CF_IDX_DEV_PORT_ID which is used to get the interface’s mac address eventually. However, the compute field array is not populated with dpdk port id at the index BNXT_ULP_CF_IDX_DEV_PORT_ID. The problem fixed by populating the compute field array correctly.
5. Some dpdk applications may accumulate the flow counters while some may not. In cases where the application is accumulating the counters the PMD need not do the accumulation itself and viceversa to report the correct flow counters.
6. Pointer to bp is added to open session parms to support shared session.
Signed-off-by: Venkat Duvvuru <venkatkumar.duvvuru@broadcom.com> Signed-off-by: Kishore Padmanabha <kishore.padmanabha@broadcom.com> Signed-off-by: Jay Ding <jay.ding@broadcom.com> Reviewed-by: Lance Richardson <lance.richardson@broadcom.com> Reviewed-by: Mike Baucom <michael.baucom@broadcom.com> Reviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com> Reviewed-by: Somnath Kotur <somnath.kotur@broadcom.com> Reviewed-by: Randy Schacher <stuart.schacher@broadcom.com>
show more ...
|
#
7891de8d |
| 30-May-2021 |
Venkat Duvvuru <venkatkumar.duvvuru@broadcom.com> |
net/bnxt: support GRE flows
This patch does the following to support GRE flows: 1. RTE_FLOW_ITEM_TYPE_ANY & RTE_FLOW_ITEM_TYPE_GRE processing 2. Calculate the absolute function ID from the logical V
net/bnxt: support GRE flows
This patch does the following to support GRE flows: 1. RTE_FLOW_ITEM_TYPE_ANY & RTE_FLOW_ITEM_TYPE_GRE processing 2. Calculate the absolute function ID from the logical VF ID passed as part of RTE_FLOW_ACTION_TYPE_VF action. 3. Move bnxt_get_bp API to bnxt_ethdev.c
Signed-off-by: Venkat Duvvuru <venkatkumar.duvvuru@broadcom.com> Reviewed-by: Somnath Kotur <somnath.kotur@broadcom.com> Reviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
show more ...
|
#
da3731e2 |
| 30-May-2021 |
Venkat Duvvuru <venkatkumar.duvvuru@broadcom.com> |
net/bnxt: check FW capability to support TRUFLOW
Currently, a devarg (host-based-truflow) is passed while launching the app to enable TRUFLOW feature. However, this mechanism adds an extra step in e
net/bnxt: check FW capability to support TRUFLOW
Currently, a devarg (host-based-truflow) is passed while launching the app to enable TRUFLOW feature. However, this mechanism adds an extra step in enabling TRUFLOW. This doesn't give a seamless experience when flow offloads has to work with FW that doesn't/does support TRUFLOW feature. Also, it's likely that customers may not want to use devarg to enable flow offloads.
This patch fixes it by checking for TRUFLOW feature support in device's capabilities and configurations field of the hwrm_ver_get.
Signed-off-by: Venkat Duvvuru <venkatkumar.duvvuru@broadcom.com> Reviewed-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com> Reviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>
show more ...
|
#
46c451d9 |
| 31-May-2021 |
Kalesh AP <kalesh-anakkur.purayil@broadcom.com> |
net/bnxt: remove unnecessary comment
Remove unnecessary comment in the code.
Fixes: 0a6d2a720078 ("net/bnxt: get device infos") Cc: stable@dpdk.org
Signed-off-by: Kalesh AP <kalesh-anakkur.purayil
net/bnxt: remove unnecessary comment
Remove unnecessary comment in the code.
Fixes: 0a6d2a720078 ("net/bnxt: get device infos") Cc: stable@dpdk.org
Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com> Reviewed-by: Somnath Kotur <somnath.kotur@broadcom.com> Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
show more ...
|
#
4a8ac376 |
| 31-May-2021 |
Kalesh AP <kalesh-anakkur.purayil@broadcom.com> |
net/bnxt: improve probing log message
The existing log message is missing a space. Modified it to a more meaningful log as part of this change.
Before this patch:
bnxt_dev_init(): bnxtfound at mem
net/bnxt: improve probing log message
The existing log message is missing a space. Modified it to a more meaningful log as part of this change.
Before this patch:
bnxt_dev_init(): bnxtfound at mem D67E0000, node addr 0x2101112000M
With this patch:
bnxt_dev_init(): Found bnxt device at mem D67E0000, node addr 0x2101112000M
Fixes: 1bf01f5135f8 ("net/bnxt: prevent device access when device is in reset") Cc: stable@dpdk.org
Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com> Reviewed-by: Somnath Kotur <somnath.kotur@broadcom.com> Reviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
show more ...
|
#
219842b9 |
| 31-May-2021 |
Somnath Kotur <somnath.kotur@broadcom.com> |
net/bnxt: workaround spurious zero stats in Thor
There is a HW bug that can result in certain stats being reported as zero. Workaround this by ignoring stats with a value of zero based on the previo
net/bnxt: workaround spurious zero stats in Thor
There is a HW bug that can result in certain stats being reported as zero. Workaround this by ignoring stats with a value of zero based on the previously stored snapshot of the same stat. This bug mainly manifests in the output of func_qstats as FW aggregrates each ring's stat value to give the per function stat and if one of them is zero, the per function stat value ends up being lower than the previous snapshot which shows up as a zero PPS value in testpmd. Eliminate invocation of func_qstats and aggregate the per-ring stat values in the driver itself to derive the func_qstats output post accounting for the spurious zero stat value.
Bugzilla ID: 641 Fixes: f8168ca0e690 ("net/bnxt: support thor controller") Cc: stable@dpdk.org
Signed-off-by: Somnath Kotur <somnath.kotur@broadcom.com> Reviewed-by: Lance Richardson <lance.richardson@broadcom.com> Reviewed-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com> Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
show more ...
|
#
c4e4c189 |
| 24-May-2021 |
Lance Richardson <lance.richardson@broadcom.com> |
net/bnxt: add AVX2 RX/Tx
Implement AVX2 vector PMD.
Signed-off-by: Lance Richardson <lance.richardson@broadcom.com> Reviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
|
#
eeded204 |
| 26-Apr-2021 |
David Marchand <david.marchand@redhat.com> |
log: register with standardized names
Let's try to enforce the convention where most drivers use a pmd. logtype with their class reflected in it, and libraries use a lib. logtype.
Introduce two new
log: register with standardized names
Let's try to enforce the convention where most drivers use a pmd. logtype with their class reflected in it, and libraries use a lib. logtype.
Introduce two new macros: - RTE_LOG_REGISTER_DEFAULT can be used when a single logtype is used in a component. It is associated to the default name provided by the build system, - RTE_LOG_REGISTER_SUFFIX can be used when multiple logtypes are used, and then the passed name is appended to the default name,
RTE_LOG_REGISTER is left untouched for existing external users and for components that do not comply with the convention.
There is a new Meson variable log_prefix to adapt the default name for baseband (pmd.bb.), bus (no pmd.) and mempool (no pmd.) classes.
Note: achieved with below commands + reverted change on net/bonding + edits on crypto/virtio, compress/mlx5, regex/mlx5
$ git grep -l RTE_LOG_REGISTER drivers/ | while read file; do pattern=${file##drivers/}; class=${pattern%%/*}; pattern=${pattern#$class/}; drv=${pattern%%/*}; case "$class" in baseband) pattern=pmd.bb.$drv;; bus) pattern=bus.$drv;; mempool) pattern=mempool.$drv;; *) pattern=pmd.$class.$drv;; esac sed -i -e 's/RTE_LOG_REGISTER(\(.*\), '$pattern',/RTE_LOG_REGISTER_DEFAULT(\1,/' $file; sed -i -e 's/RTE_LOG_REGISTER(\(.*\), '$pattern'\.\(.*\),/RTE_LOG_REGISTER_SUFFIX(\1, \2,/' $file; done
$ git grep -l RTE_LOG_REGISTER lib/ | while read file; do pattern=${file##lib/}; pattern=lib.${pattern%%/*}; sed -i -e 's/RTE_LOG_REGISTER(\(.*\), '$pattern',/RTE_LOG_REGISTER_DEFAULT(\1,/' $file; sed -i -e 's/RTE_LOG_REGISTER(\(.*\), '$pattern'\.\(.*\),/RTE_LOG_REGISTER_SUFFIX(\1, \2,/' $file; done
Signed-off-by: David Marchand <david.marchand@redhat.com> Signed-off-by: Thomas Monjalon <thomas@monjalon.net> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
show more ...
|
#
c967098a |
| 03-May-2021 |
Kalesh AP <kalesh-anakkur.purayil@broadcom.com> |
net/bnxt: prevent device access in error state
Driver should prevent any DMA with the device when it detects an error. When firmware is in fatal state, stop tx/rx by assigning them to dummy function
net/bnxt: prevent device access in error state
Driver should prevent any DMA with the device when it detects an error. When firmware is in fatal state, stop tx/rx by assigning them to dummy functions.
Fixes: be14720def9c ("net/bnxt: support FW reset") Fixes: 9d0cbaecc91a ("net/bnxt: support periodic FW health monitoring") Cc: stable@dpdk.org
Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com> Reviewed-by: Somnath Kotur <somnath.kotur@broadcom.com> Reviewed-by: Andy Gospodarek <gospo@broadcom.com> Reviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
show more ...
|
#
52c33734 |
| 30-Apr-2021 |
Ajit Khaparde <ajit.khaparde@broadcom.com> |
net/bnxt: check PCI config read
Return value where return value of rte_pci_read_config was not checked. Fix it.
Coverity issue: 349919 Fixes: 9d0cbaecc91a ("net/bnxt: support periodic FW health mon
net/bnxt: check PCI config read
Return value where return value of rte_pci_read_config was not checked. Fix it.
Coverity issue: 349919 Fixes: 9d0cbaecc91a ("net/bnxt: support periodic FW health monitoring") Cc: stable@dpdk.org
Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com> Reviewed-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com> Reviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>
show more ...
|
#
c8e81543 |
| 30-Apr-2021 |
Ajit Khaparde <ajit.khaparde@broadcom.com> |
net/bnxt: fix mismatched type comparison in MAC restore
dev_info.max_mac_addrs is of type uint32_t. But the counter i is of type uint16_t. This mismatch may cause the loop condition may always be tr
net/bnxt: fix mismatched type comparison in MAC restore
dev_info.max_mac_addrs is of type uint32_t. But the counter i is of type uint16_t. This mismatch may cause the loop condition may always be true. Change the loop counter variable to uint32_t.
Fixes: b02f1573cd07 ("net/bnxt: restore MAC filters during reset recovery") Cc: stable@dpdk.org
Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com> Reviewed-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
show more ...
|
#
7712a39c |
| 29-Apr-2021 |
Kalesh AP <kalesh-anakkur.purayil@broadcom.com> |
net/bnxt: fix single PF per port check
The check BNXT_SINGLE_PF(bp) returns false for a VF. So there is no extra check needed for VF along with BNXT_SINGLE_PF(bp).
Also make error messages more exp
net/bnxt: fix single PF per port check
The check BNXT_SINGLE_PF(bp) returns false for a VF. So there is no extra check needed for VF along with BNXT_SINGLE_PF(bp).
Also make error messages more explicit.
Fixes: ff947c6ce15f ("net/bnxt: add check for multi host PF per port") Fixes: f86febfb46da ("net/bnxt: support VF") Fixes: 3e12fdb78e82 ("net/bnxt: support VLAN pvid") Cc: stable@dpdk.org
Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com> Reviewed-by: Somnath Kotur <somnath.kotur@broadcom.com> Reviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
show more ...
|
#
f8120fd0 |
| 26-Apr-2021 |
Somnath Kotur <somnath.kotur@broadcom.com> |
net/bnxt: fix Rx timestamp when FIFO pending bit is set
Fix to clear the Rx FIFO while reading the timestamp. If the Rx FIFO has pending bit set, keep reading to clear it and return the last valid t
net/bnxt: fix Rx timestamp when FIFO pending bit is set
Fix to clear the Rx FIFO while reading the timestamp. If the Rx FIFO has pending bit set, keep reading to clear it and return the last valid timestamp instead of unconditionally returning an error.
Fixes: b11cceb83a34 ("net/bnxt: support timesync") Cc: stable@dpdk.org
Signed-off-by: Somnath Kotur <somnath.kotur@broadcom.com> Reviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
show more ...
|
#
d345d6c9 |
| 21-Apr-2021 |
Ferruh Yigit <ferruh.yigit@intel.com> |
drivers/net: fix FW version query
Fixes a few different things: * Remove 'fw_version' NULL checks, it is allowed if the 'fw_size' is zero, 'fw_version' being NULL but 'fw_size' not zero condition
drivers/net: fix FW version query
Fixes a few different things: * Remove 'fw_version' NULL checks, it is allowed if the 'fw_size' is zero, 'fw_version' being NULL but 'fw_size' not zero condition checked in ethdev layer * Be sure required buffer size is returned if provided one is not big enough, instead of returning success (0) * Document in doxygen comment the '-EINVAL' is a valid return type * Take into account that 'snprintf' can return negative value * Cast length to 'size_t' to compare it with 'fw_size'
Fixes: bb42aa9ffe4e ("net/atlantic: configure device start/stop") Fixes: ff70acdf4299 ("net/axgbe: support reading FW version") Fixes: e2652b0a20a0 ("net/bnxt: support get FW version") Fixes: cf0fab1d2ca5 ("net/dpaa: support firmware version get API") Fixes: 748eccb97cdc ("net/dpaa2: add support for firmware version get") Fixes: b883c0644a24 ("net/e1000: add firmware version get") Fixes: 293430677e9c ("net/enic: add handler to return firmware version") Fixes: 1f5ca0b460cd ("net/hns3: support some device operations") Fixes: bd5b86732bc7 ("net/hns3: modify format for firmware version") Fixes: ed0dfdd0e976 ("net/i40e: add firmware version get") Fixes: e31cb9a36298 ("net/ice: support FW version getting") Fixes: 4f09bc55ac3d ("net/igc: implement device base operations") Fixes: eec10fb0ce6b ("net/ionic: support FW version") Fixes: 8b0b56574269 ("net/ixgbe: add firmware version get") Fixes: 4d9f5b8adc02 ("net/octeontx2: add FW version get operation") Fixes: f97b56f9f12e ("net/qede: support FW version query") Fixes: 83fef46a22b2 ("net/sfc: add callback to retrieve FW version") Fixes: bc84ac0fadef ("net/txgbe: support getting FW version") Fixes: 21913471202f ("ethdev: add firmware version get") Cc: stable@dpdk.org
Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com> Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com> Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru> Acked-by: Haiyue Wang <haiyue.wang@intel.com> Acked-by: Rasesh Mody <rmody@marvell.com> Acked-by: Jiawen Wu <jiawenwu@trustnetic.com> Acked-by: Beilei Xing <beilei.xing@intel.com> Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>
show more ...
|
#
d723d1fe |
| 20-Apr-2021 |
Kalesh AP <kalesh-anakkur.purayil@broadcom.com> |
net/bnxt: fix health check alarm cancellation
Driver cancels the health check alarm only if error recovery is enabled in the FW. This can cause an issue. There is a small window where the driver rec
net/bnxt: fix health check alarm cancellation
Driver cancels the health check alarm only if error recovery is enabled in the FW. This can cause an issue. There is a small window where the driver receives the async event from FW and port close is invoked immediately. Driver clears BNXT_FLAG_RECOVERY_ENABLED flag when it gets the async event from FW. As a result, the health check alarm will not get canceled during port close and causes a segfault when the alarm tries to read Heartbeat register.
Fix this by canceling the health check alarm unconditionally during port stop.
Fixes: 9d0cbaecc91a ("net/bnxt: support periodic FW health monitoring") Cc: stable@dpdk.org
Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com> Reviewed-by: Somnath Kotur <somnath.kotur@broadcom.com> Reviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
show more ...
|
#
fe8dd26f |
| 14-Apr-2021 |
Ajit Khaparde <ajit.khaparde@broadcom.com> |
net/bnxt: cap max Rx rings for Thor
For Thor devices, RSS table can only accommodate 512 Rx queues. When RSS is enabled, Cap the max Rx rings to 512. For non-RSS case, the number will be limited by
net/bnxt: cap max Rx rings for Thor
For Thor devices, RSS table can only accommodate 512 Rx queues. When RSS is enabled, Cap the max Rx rings to 512. For non-RSS case, the number will be limited by number of VNICs.
Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com> Reviewed-by: Lance Richardson <lance.richardson@broadcom.com>
show more ...
|
#
e2895305 |
| 08-Apr-2021 |
Ajit Khaparde <ajit.khaparde@broadcom.com> |
net/bnxt: fix resource cleanup
Fix resource cleanup in port close. Once the pointers are freed, set them to NULL. Make sure access to the pointers is validated before use.
Fixes: bb81e07323bb ("net
net/bnxt: fix resource cleanup
Fix resource cleanup in port close. Once the pointers are freed, set them to NULL. Make sure access to the pointers is validated before use.
Fixes: bb81e07323bb ("net/bnxt: support LED on/off") Fixes: 804e746c7b73 ("net/bnxt: add hardware resource manager init code") Fixes: 1d0704f4d793 ("net/bnxt: add device configure operation") Fixes: 698aa7e95325 ("net/bnxt: add code to determine the Tx COS queue") Fixes: 322bd6e70272 ("net/bnxt: add port representor infrastructure") Fixes: 0bf5a0b5ebb8 ("net/bnxt: add a failure log") Cc: stable@dpdk.org
Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
show more ...
|
#
e73fb98b |
| 02-Apr-2021 |
Kalesh AP <kalesh-anakkur.purayil@broadcom.com> |
net/bnxt: fix configuring LRO
While configuring LRO, driver should check the return value of bnxt_hwrm_vnic_tpa_cfg() HWRM command and return error when the FW command fails.
Fixes: 0958d8b6435d ("
net/bnxt: fix configuring LRO
While configuring LRO, driver should check the return value of bnxt_hwrm_vnic_tpa_cfg() HWRM command and return error when the FW command fails.
Fixes: 0958d8b6435d ("net/bnxt: support LRO") Cc: stable@dpdk.org
Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com> Reviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>
show more ...
|